Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Issue 11587012: Introduce mac_want_real_dsym GYP flag. By default, fake .dSYM files (Closed)

Created:
8 years ago by Alexander Potapenko
Modified:
8 years ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews, Mark Mentovai
Visibility:
Public.

Description

Introduce mac_want_real_dsym GYP flag. By default, fake .dSYM files will be generated for regular builds, and dsymutils will be used to create .dSYMs for ASan builds. mac_want_real_dsym can be used to override this. mac_real_dsym can't be set directly, because it's not a % variable. According to https://codereview.chromium.org/113999, it can't be made a % variable now, because of a bug in % handling in GYP that leads to mac_real_dsym being unconditionally set to 1 for some targets. BUG=148383 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173749

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M build/common.gypi View 3 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Alexander Potapenko
Please take a look. I've decided to let the users override the default, because it's ...
8 years ago (2012-12-17 17:30:01 UTC) #1
Nico
The change looks fine, but can you update the CL description to include a bit ...
8 years ago (2012-12-18 00:38:25 UTC) #2
Alexander Potapenko
Updated the description. Mark, is there a bug ID for the % issue?
8 years ago (2012-12-18 10:35:39 UTC) #3
Mark Mentovai
Not that I recall, but it’s been 3 1/2 years.
8 years ago (2012-12-18 13:33:54 UTC) #4
Alexander Potapenko
Nico, please consider pressing the CQ checkbox iff the change looks good now.
8 years ago (2012-12-18 14:36:26 UTC) #5
Nico
lgtm
8 years ago (2012-12-18 15:56:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/11587012/12002
8 years ago (2012-12-18 15:56:44 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-18 17:50:00 UTC) #8
Message was sent while issue was closed.
Change committed as 173749

Powered by Google App Engine
This is Rietveld 408576698