Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11585008: Remove call to IsInstantExtendedAPIGoogleSearchUrl from SearchTabHelper. (Closed)

Created:
8 years ago by beaudoin
Modified:
7 years, 11 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, dhollowa+watch_chromium.org, sreeram, Jered
Visibility:
Public.

Description

Remove call to IsInstantExtendedAPIGoogleSearchUrl from SearchTabHelper. This patch ensures SearchTabHelper no longer relies on the hardcoded "espv" parameter. Depends on: https://codereview.chromium.org/11552020/ https://codereview.chromium.org/11576044/ BUG=161602 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175910

Patch Set 1 #

Patch Set 2 : Update following changes in previous CLs. #

Patch Set 3 : Rebased #

Patch Set 4 : Fixed unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M chrome/browser/ui/search/search_tab_helper.cc View 1 2 3 4 chunks +27 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
beaudoin
@David: for review and owner's approval @Jered, Sreeram: If you have time to make sure ...
8 years ago (2012-12-15 00:05:35 UTC) #1
dhollowa
lgtm
7 years, 11 months ago (2013-01-08 20:57:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaudoin@chromium.org/11585008/7001
7 years, 11 months ago (2013-01-09 16:40:39 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) unit_tests
7 years, 11 months ago (2013-01-09 17:18:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaudoin@chromium.org/11585008/7002
7 years, 11 months ago (2013-01-09 18:25:56 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests
7 years, 11 months ago (2013-01-09 20:00:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaudoin@chromium.org/11585008/7002
7 years, 11 months ago (2013-01-09 20:50:59 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 23:08:08 UTC) #8
Message was sent while issue was closed. 
Change committed as 175910

Powered by Google App Engine
This is Rietveld 408576698