Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Side by Side Diff: build/android/PRESUBMIT.py

Issue 11583028: Add a presubmit check to check that a certain set of Android specific files only have deletions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved to build/android per ilevy's suggestion Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for android buildbot. 5 """Presubmit script for android buildbot.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8 details on the presubmit API built into gcl. 8 details on the presubmit API built into gcl.
9 """ 9 """
10 10
11 _DELETIONS_ONLY_FILES = (
12 'build/android/findbugs_filter/findbugs_known_bugs.txt',
13 )
14
15
16 def _CheckDeletionsOnlyFiles(input_api, output_api):
17 """Check that a certain listed files only have deletions.
18 """
19 errors = []
20 for f in input_api.AffectedFiles():
21 if f.LocalPath() in _DELETIONS_ONLY_FILES:
22 if f.ChangedContents():
23 errors.append(f.LocalPath())
24 results = []
25 if errors:
26 results.append(output_api.PresubmitError(
27 'Following files should only contain deletions.', errors))
28 return results
29
30
11 def CommonChecks(input_api, output_api): 31 def CommonChecks(input_api, output_api):
12 output = [] 32 output = []
13 33
14 def J(*dirs): 34 def J(*dirs):
15 """Returns a path relative to presubmit directory.""" 35 """Returns a path relative to presubmit directory."""
16 return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs) 36 return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs)
17 37
18 output.extend(input_api.canned_checks.RunPylint( 38 output.extend(input_api.canned_checks.RunPylint(
19 input_api, 39 input_api,
20 output_api, 40 output_api,
21 white_list=[r'PRESUBMIT\.py$', r'buildbot/.*\.py$'], 41 white_list=[r'PRESUBMIT\.py$', r'buildbot/.*\.py$'],
22 extra_paths_list=[ 42 extra_paths_list=[
23 J(), J('..', '..', 'third_party', 'android_testrunner')])) 43 J(), J('..', '..', 'third_party', 'android_testrunner')]))
24 44
25 output.extend(input_api.canned_checks.RunUnitTestsInDirectory( 45 output.extend(input_api.canned_checks.RunUnitTestsInDirectory(
26 input_api, output_api, J('buildbot', 'tests'))) 46 input_api, output_api, J('buildbot', 'tests')))
47 output.extend(_CheckDeletionsOnlyFiles(input_api, output_api))
27 return output 48 return output
28 49
29 50
30 def CheckChangeOnUpload(input_api, output_api): 51 def CheckChangeOnUpload(input_api, output_api):
31 return CommonChecks(input_api, output_api) 52 return CommonChecks(input_api, output_api)
32 53
33 54
34 def CheckChangeOnCommit(input_api, output_api): 55 def CheckChangeOnCommit(input_api, output_api):
35 return CommonChecks(input_api, output_api) 56 return CommonChecks(input_api, output_api)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698