Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/socket/client_socket_pool_base.cc

Issue 11583027: NetLog: Move the group_name to a CONNECT_JOB's first event. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Add backward compatibility Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/net_log_event_type_list.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/client_socket_pool_base.cc
===================================================================
--- net/socket/client_socket_pool_base.cc (revision 174698)
+++ net/socket/client_socket_pool_base.cc (working copy)
@@ -77,7 +77,8 @@
idle_(true) {
DCHECK(!group_name.empty());
DCHECK(delegate);
- net_log.BeginEvent(NetLog::TYPE_SOCKET_POOL_CONNECT_JOB);
+ net_log.BeginEvent(NetLog::TYPE_SOCKET_POOL_CONNECT_JOB,
+ NetLog::StringCallback("group_name", &group_name_));
}
ConnectJob::~ConnectJob() {
@@ -125,8 +126,7 @@
}
void ConnectJob::LogConnectStart() {
- net_log().BeginEvent(NetLog::TYPE_SOCKET_POOL_CONNECT_JOB_CONNECT,
- NetLog::StringCallback("group_name", &group_name_));
+ net_log().BeginEvent(NetLog::TYPE_SOCKET_POOL_CONNECT_JOB_CONNECT);
}
void ConnectJob::LogConnectCompletion(int net_error) {
« no previous file with comments | « net/base/net_log_event_type_list.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698