Issue 11583027: NetLog: Move the group_name to a CONNECT_JOB's first event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11583027: NetLog: Move the group_name to a CONNECT_JOB's first event. (Closed)

Created:
7 years, 12 months ago by mmenke

Modified:
7 years, 11 months ago

Reviewers:
eroman

CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, darin-cc_chromium.org, arv (Not doing code reviews), mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

NetLog: Move the group_name to a CONNECT_JOB's first event. This fixes jobs with a SOCKET_BACKUP_CREATED event as the second event not having a description. Also simplifies the net-internals code slightly (Or will once backward compatibility can be removed). This slightly breaks compatibility of old versions of Chrome with new log files - CONNECT_JOBs and SOCKETS from newer versions of Chrome will not have descriptions on M25 or earlier. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175088

Patch Set 1 #

Patch Set 2 : Add backward compatibility #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -8 lines)			Patch
M	chrome/browser/resources/net_internals/source_entry.js	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	net/base/net_log_event_type_list.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	net/socket/client_socket_pool_base.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mmenke

Despite the loss of compatibility, think this is a better solution than look ahead, over ...

7 years, 11 months ago (2012-12-28 19:12:08 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/11583027/12001

7 years, 11 months ago (2013-01-04 00:35:18 UTC) #3

Message was sent while issue was closed.

Change committed as 175088

Expand Messages | Collapse Messages