Issue 11583013: Ensure keymessage response to generateKeyRequest() has keySystem set for external CDMs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11583013: Ensure keymessage response to generateKeyRequest() has keySystem set for external CDMs. (Closed)

Created:
8 years ago by ddorwin

Modified:
8 years ago

Reviewers:
xhwang

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Ensure keymessage response to generateKeyRequest() has keySystem set for external CDMs. Always post a task for all EME app-facing events, which was the intention when calling CallOnMain(). Also added DCHECKs to avoid sending empty keySystem and refactored the code a bit to minimize the number of paths. BUG=166204 TEST=Enabled check in encrypted_media_utils.js Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173303

Patch Set 1 #

Patch Set 2 : rebased on 11469040 #

Patch Set 3 : rebase #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -16 lines)			Patch
	M	content/test/data/media/encrypted_media_utils.js	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
	M	webkit/media/crypto/ppapi/cdm_wrapper.cc	View		8 chunks	+27 lines, -14 lines	0 comments	Download