Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11580006: [Android] Output unchecked warnings and fix existing instances. (Closed)

Created:
8 years ago by Yaron
Modified:
8 years ago
CC:
chromium-reviews, ilevy+watch_chromium.org, feature-media-reviews_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] Output unchecked warnings and fix existing instances. BUG=164395 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M build/android/ant/chromium-jars.xml View 1 chunk +8 lines, -7 lines 0 comments Download
M build/android/ant/sdk-targets.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java View 2 chunks +2 lines, -1 line 0 comments Download
M media/base/android/java/src/org/chromium/media/MediaPlayerBridge.java View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Yaron
8 years ago (2012-12-17 23:34:59 UTC) #1
cjhopman
lgtm
8 years ago (2012-12-17 23:36:43 UTC) #2
Isaac (away)
drive by lgtm can we have this warning be a build error?
8 years ago (2012-12-17 23:53:53 UTC) #3
Yaron
On 2012/12/17 23:53:53, Isaac wrote: > drive by lgtm > > can we have this ...
8 years ago (2012-12-17 23:54:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/11580006/1
8 years ago (2012-12-18 00:02:05 UTC) #5
nyquist
lgtm
8 years ago (2012-12-18 00:04:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/11580006/1
8 years ago (2012-12-18 01:14:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/11580006/1
8 years ago (2012-12-18 02:00:25 UTC) #8
commit-bot: I haz the power
8 years ago (2012-12-18 06:56:15 UTC) #9
Message was sent while issue was closed. 
Change committed as 173658

Powered by Google App Engine
This is Rietveld 408576698