Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11578052: Replace OncNetworkParser by the new ONC translator. (Closed)

Created:
8 years ago by pneubeck (no reviews)
Modified:
7 years, 11 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@extend_onc_to_shill
Visibility:
Public.

Description

Replace OncNetworkParser by the new ONC translator. BUG=162040 TBR=jochen@chromium.org (gypi changes), bartfab@chromium.org (minor policy change) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176520

Patch Set 1 #

Total comments: 9

Patch Set 2 : Rebased with adaptions. #

Patch Set 3 : Added more tests. Adapted old test to new implementation. #

Patch Set 4 : Added more tests. Applying device policy restrictions during validation. #

Patch Set 5 : Rebased. #

Patch Set 6 : Fixed nits. #

Patch Set 7 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+677 lines, -3096 lines) Patch
M chrome/browser/chromeos/cros/network_library.h View 1 2 3 4 5 3 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_base.cc View 1 2 3 4 5 6 chunks +93 lines, -50 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_stub.h View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_stub.cc View 1 2 3 4 8 chunks +32 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_unittest.cc View 1 2 3 7 chunks +186 lines, -77 lines 0 comments Download
D chrome/browser/chromeos/cros/onc_network_parser.h View 1 chunk +0 lines, -286 lines 0 comments Download
D chrome/browser/chromeos/cros/onc_network_parser.cc View 1 chunk +0 lines, -1515 lines 0 comments Download
D chrome/browser/chromeos/cros/onc_network_parser_unittest.cc View 1 2 3 4 1 chunk +0 lines, -594 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_chromeos.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 1 chunk +4 lines, -1 line 0 comments Download
D chrome/test/data/chromeos/cros/cert-pattern.onc View 1 2 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/test/data/chromeos/cros/cert-pattern-vpn.onc View 1 2 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/test/data/chromeos/cros/network-ethernet.onc View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/test/data/chromeos/cros/network-l2tp-ipsec.onc View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/test/data/chromeos/cros/network-multiple-unknown.onc View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/test/data/chromeos/cros/network-openvpn.onc View 1 2 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/test/data/chromeos/cros/network-unknown-fields.onc View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/chromeos/cros/network-wifi.onc View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/test/data/chromeos/cros/network-wifi-eap1.onc View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/test/data/chromeos/cros/network-wifi-eap2.onc View 1 2 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/test/data/chromeos/cros/network-wifi-none.onc View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/test/data/chromeos/cros/network-wifi-proxy-direct.onc View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/test/data/chromeos/cros/network-wifi-proxy-manual.onc View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/test/data/chromeos/cros/network-wifi-proxy-pac.onc View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/chromeos/cros/network-wifi-proxy-wpad.onc View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/test/data/chromeos/cros/network-wifi-remove.onc View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/chromeos/cros/network-wifi-wep.onc View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/test/data/chromeos/cros/network-wifi-wpa.onc View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/test/data/chromeos/cros/network-wifi-wpa-remove.onc View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
A chrome/test/data/chromeos/net/shill_for_managed_toplevel1.json View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/test/data/chromeos/net/shill_for_managed_toplevel2.json View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download
A chrome/test/data/chromeos/net/shill_for_managed_toplevel_l2tpipsec.json View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/test/data/chromeos/net/shill_for_managed_toplevel_wifi_peap.json View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/test/data/chromeos/net/shill_for_toplevel_openvpn_clientcert.json View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/test/data/chromeos/net/shill_for_toplevel_partially_invalid.json View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/test/data/chromeos/net/shill_for_toplevel_wifi_eap_clientcert.json View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/test/data/chromeos/net/shill_for_toplevel_wifi_leap.json View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/test/data/chromeos/net/shill_for_toplevel_wifi_open.json View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/chromeos/net/shill_for_toplevel_wifi_remove.json View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/test/data/chromeos/net/shill_for_toplevel_wifi_wep_proxy.json View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/test/data/chromeos/net/shill_for_toplevel_wifi_wpa_psk.json View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/test/data/chromeos/net/shill_for_toplevel_with_unknown_fields.json View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/test/functional/chromeos_onc.py View 1 2 6 chunks +11 lines, -11 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M chromeos/network/onc/onc_test_utils.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/network/onc/onc_test_utils.cc View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
M chromeos/network/onc/onc_validator.h View 1 2 3 4 chunks +14 lines, -0 lines 0 comments Download
M chromeos/network/onc/onc_validator.cc View 1 2 3 4 5 6 chunks +37 lines, -0 lines 0 comments Download
M chromeos/network/onc/onc_validator_unittest.cc View 1 2 3 5 chunks +34 lines, -4 lines 0 comments Download
M chromeos/test/data/network/managed_toplevel1.onc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D chromeos/test/data/network/managed_toplevel_cpanel.onc View 1 2 1 chunk +0 lines, -40 lines 0 comments Download
A + chromeos/test/data/network/managed_toplevel_l2tpipsec.onc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chromeos/test/data/network/managed_toplevel_wifi_peap.onc View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chromeos/test/data/network/toplevel_openvpn_clientcert.onc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chromeos/test/data/network/toplevel_partially_invalid.onc View 1 2 3 3 chunks +8 lines, -3 lines 0 comments Download
A + chromeos/test/data/network/toplevel_wifi_eap_clientcert.onc View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chromeos/test/data/network/toplevel_wifi_leap.onc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chromeos/test/data/network/toplevel_wifi_open.onc View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chromeos/test/data/network/toplevel_wifi_remove.onc View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chromeos/test/data/network/toplevel_wifi_wep_proxy.onc View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chromeos/test/data/network/toplevel_wifi_wpa_psk.onc View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chromeos/test/data/network/toplevel_with_unknown_fields.onc View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 2 3 4 5 6 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
pneubeck (no reviews)
Based on the two other CLs https://codereview.chromium.org/11664005/ https://codereview.chromium.org/11662004/ this CL finally removes the OncNetworkParser. Yeah ...
8 years ago (2012-12-21 15:18:03 UTC) #1
stevenjb
lgtm https://codereview.chromium.org/11578052/diff/1/chrome/browser/chromeos/cros/network_library_impl_base.cc File chrome/browser/chromeos/cros/network_library_impl_base.cc (right): https://codereview.chromium.org/11578052/diff/1/chrome/browser/chromeos/cros/network_library_impl_base.cc#newcode1043 chrome/browser/chromeos/cros/network_library_impl_base.cc:1043: content::BrowserThread::UI) || This is an odd place for ...
8 years ago (2012-12-21 18:38:36 UTC) #2
stevenjb
Note: again, that's an lg for owner purposes - I would wait for greg's OK ...
8 years ago (2012-12-21 18:39:25 UTC) #3
Greg Spencer (Chromium)
LGTM. Yay for removing old code! https://codereview.chromium.org/11578052/diff/1/chrome/browser/chromeos/cros/network_library_unittest.cc File chrome/browser/chromeos/cros/network_library_unittest.cc (right): https://codereview.chromium.org/11578052/diff/1/chrome/browser/chromeos/cros/network_library_unittest.cc#newcode371 chrome/browser/chromeos/cros/network_library_unittest.cc:371: // } Yes, ...
8 years ago (2012-12-21 19:36:43 UTC) #4
pneubeck (no reviews)
Addressed comments. Added new and adapted old tests. https://codereview.chromium.org/11578052/diff/1/chrome/browser/chromeos/cros/network_library_impl_base.cc File chrome/browser/chromeos/cros/network_library_impl_base.cc (right): https://codereview.chromium.org/11578052/diff/1/chrome/browser/chromeos/cros/network_library_impl_base.cc#newcode1043 chrome/browser/chromeos/cros/network_library_impl_base.cc:1043: content::BrowserThread::UI) ...
7 years, 11 months ago (2013-01-09 17:04:05 UTC) #5
pneubeck (no reviews)
Ignore the previous mail, which was on the wrong CL. @Craig, could you please take ...
7 years, 11 months ago (2013-01-10 21:39:46 UTC) #6
craigdh
PyAuto bits lgtm.
7 years, 11 months ago (2013-01-11 17:29:39 UTC) #7
Greg Spencer (Chromium)
network_library_impl_base.cc updates LGTM
7 years, 11 months ago (2013-01-11 17:48:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/11578052/44001
7 years, 11 months ago (2013-01-11 20:39:47 UTC) #9
commit-bot: I haz the power
7 years, 11 months ago (2013-01-12 09:13:26 UTC) #10
Message was sent while issue was closed. 
Change committed as 176520

Powered by Google App Engine
This is Rietveld 408576698