Rejecting networks/certificates independently on ONC import and policy loading.

Rejecting networks/certificates independently on ONC import and policy loading.

Adapted NetworkLibrary and onc::CertificateImporter.

BUG=162801
TEST=Import an ONC with one invalid and one valid network/certificate.
Ensure that the valid one is correctly imported.
TBR=eroman@chromium.org (net_internals, string change)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173444

[pneubeck (no reviews), 2012-12-13 15:03:06]

This is the second part of https://codereview.chromium.org/11428078/.

[stevenjb, 2012-12-14 01:09:15]

https://codereview.chromium.org/11578005/diff/2001/chrome/browser/chromeos/cr...
File chrome/browser/chromeos/cros/network_library_impl_base.cc (right):

https://codereview.chromium.org/11578005/diff/2001/chrome/browser/chromeos/cr...
chrome/browser/chromeos/cros/network_library_impl_base.cc:1088: bool
error_occurred = false;
nit: 'success = true' would match the return value and be a little more
readable.

[Greg Spencer (Chromium), 2012-12-14 18:17:48]

lgtm

[pneubeck (no reviews), 2012-12-14 19:34:12]

@Steven, addressed your comment.

According to the previous commit, onc::Validator doesn't abort LoadOncNetworks
anymore. But at least, it returns false after this CL and a message on the
net_internals page is shown.

[stevenjb, 2012-12-14 20:22:12]

lgtm

[pneubeck (no reviews), 2012-12-14 22:10:22]

@Joao, a trivial change in
chrome/browser/policy/network_configuration_updater.cc

[Joao da Silva, 2012-12-14 22:15:06]

policy/ lgtm

[commit-bot: I haz the power, 2012-12-17 08:37:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/11578005/7002

[commit-bot: I haz the power, 2012-12-17 08:37:35]

Presubmit check for 11578005-7002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/webui/net_internals

Presubmit checks took 1.2s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-12-17 08:53:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/11578005/7002

[commit-bot: I haz the power, 2012-12-17 11:55:58]

Change committed as 173444