src/string.js - Issue 11576069: Correctly handle negative codes in String.fromCharCode()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/string.js

Issue 11576069: Correctly handle negative codes in String.fromCharCode() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/string.js

diff --git a/src/string.js b/src/string.js

index badfad353603a9ae2214f806e0cd30911c297521..d9ca035fb5f32983d34bc970fa24867f0acce268 100644

--- a/src/string.js

+++ b/src/string.js

@@ -824,6 +824,7 @@ function StringFromCharCode(code) {

for (i = 0; i < n; i++) {

var code = %_Arguments(i);

if (!%_IsSmi(code)) code = ToNumber(code) & 0xffff;

+ if (code < 0) code = code & 0xffff;

if (code > 0x7f) break;

%_OneByteSeqStringSetChar(one_byte, i, code);

}

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-166553.js » ('j') | no next file with comments »