Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11576065: Improved GAIA cookie retrieval logic in ChromeOS login (Closed)

Created:
8 years ago by zel
Modified:
8 years ago
Reviewers:
xiyuan, Sumit
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Improved GAIA cookie retrieval logic in ChromeOS login * /MergeSession should not really run when we do cookie jar transfer * cookie jar transfer should be running just for new users and not be running for users who went through OAuth1 recovery (i.e. pwd change) BUG=166919 TEST=existing ChromeOS integration tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174356

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : before removing cookie change detection #

Patch Set 5 : removed cookie change detection #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 11

Patch Set 8 : #

Total comments: 2

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -77 lines) Patch
M chrome/browser/chromeos/login/login_utils.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 3 4 5 6 7 8 9 10 11 7 chunks +91 lines, -52 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 7 chunks +27 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/profile_auth_data.h View 1 2 3 2 chunks +13 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/profile_auth_data.cc View 1 2 3 4 5 6 7 8 9 3 chunks +67 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
zel
8 years ago (2012-12-20 00:46:33 UTC) #1
xiyuan
https://codereview.chromium.org/11576065/diff/11001/chrome/browser/chromeos/login/login_utils.cc File chrome/browser/chromeos/login/login_utils.cc (right): https://codereview.chromium.org/11576065/diff/11001/chrome/browser/chromeos/login/login_utils.cc#newcode561 chrome/browser/chromeos/login/login_utils.cc:561: has_web_auth_cookies_, // transfer_cookies nit: two-space after comma https://codereview.chromium.org/11576065/diff/11001/chrome/browser/chromeos/login/login_utils.cc#newcode639 chrome/browser/chromeos/login/login_utils.cc:639: ...
8 years ago (2012-12-20 01:57:45 UTC) #2
zel
https://codereview.chromium.org/11576065/diff/11001/chrome/browser/chromeos/login/login_utils.cc File chrome/browser/chromeos/login/login_utils.cc (right): https://codereview.chromium.org/11576065/diff/11001/chrome/browser/chromeos/login/login_utils.cc#newcode561 chrome/browser/chromeos/login/login_utils.cc:561: has_web_auth_cookies_, // transfer_cookies On 2012/12/20 01:57:45, xiyuan wrote: > ...
8 years ago (2012-12-20 16:56:19 UTC) #3
xiyuan
LGTM https://codereview.chromium.org/11576065/diff/13001/chrome/browser/chromeos/login/profile_auth_data.cc File chrome/browser/chromeos/login/profile_auth_data.cc (right): https://codereview.chromium.org/11576065/diff/13001/chrome/browser/chromeos/login/profile_auth_data.cc#newcode28 chrome/browser/chromeos/login/profile_auth_data.cc:28: const char kGoogleAccountsDomain[] = "accounts.google.com"; These seem unused. ...
8 years ago (2012-12-20 17:03:32 UTC) #4
zel
https://codereview.chromium.org/11576065/diff/13001/chrome/browser/chromeos/login/profile_auth_data.cc File chrome/browser/chromeos/login/profile_auth_data.cc (right): https://codereview.chromium.org/11576065/diff/13001/chrome/browser/chromeos/login/profile_auth_data.cc#newcode28 chrome/browser/chromeos/login/profile_auth_data.cc:28: const char kGoogleAccountsDomain[] = "accounts.google.com"; On 2012/12/20 17:03:32, xiyuan ...
8 years ago (2012-12-20 17:44:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/11576065/15001
8 years ago (2012-12-20 17:44:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/11576065/6009
8 years ago (2012-12-20 18:47:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/11576065/5012
8 years ago (2012-12-20 19:01:35 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests
8 years ago (2012-12-20 20:54:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/11576065/2013
8 years ago (2012-12-21 02:31:03 UTC) #10
commit-bot: I haz the power
8 years ago (2012-12-21 07:39:18 UTC) #11
Message was sent while issue was closed. 
Change committed as 174356

Powered by Google App Engine
This is Rietveld 408576698