Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: tools/telemetry/telemetry/core/chrome/desktop_browser_finder.py

Issue 11576050: [Telemetry] Add memory and IO stats to page cycler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address dtu nits Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/chrome/desktop_browser_finder.py
diff --git a/tools/telemetry/telemetry/core/chrome/desktop_browser_finder.py b/tools/telemetry/telemetry/core/chrome/desktop_browser_finder.py
index 54757b96627d840a8d18f3d29566a229ab44da1f..1abfc1ecbf30e7ad235dbbb3581a684ceabc2400 100644
--- a/tools/telemetry/telemetry/core/chrome/desktop_browser_finder.py
+++ b/tools/telemetry/telemetry/core/chrome/desktop_browser_finder.py
@@ -11,7 +11,9 @@ import sys
from telemetry.core import browser
from telemetry.core import possible_browser
from telemetry.core.chrome import desktop_browser_backend
-from telemetry.core.chrome import platform
+from telemetry.core.chrome import linux_platform_backend
+from telemetry.core.chrome import mac_platform_backend
+from telemetry.core.chrome import win_platform_backend
ALL_BROWSER_TYPES = ','.join([
'exact',
@@ -36,7 +38,15 @@ class PossibleDesktopBrowser(possible_browser.PossibleBrowser):
def Create(self):
backend = desktop_browser_backend.DesktopBrowserBackend(
self._options, self._local_executable, self._is_content_shell)
- b = browser.Browser(backend, platform.EmptyPlatform())
+ if sys.platform.startswith('linux'):
+ p = linux_platform_backend.LinuxPlatformBackend()
+ elif sys.platform == 'darwin':
+ p = mac_platform_backend.MacPlatformBackend()
+ elif sys.platform == 'win32':
+ p = win_platform_backend.WinPlatformBackend()
+ else:
+ raise NotImplementedError()
+ b = browser.Browser(backend, p)
backend.SetBrowser(b)
return b

Powered by Google App Engine
This is Rietveld 408576698