Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11575015: adding render stats for deferred image decoding (Closed)

Created:
8 years ago by qinmin
Modified:
8 years ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, cc-bugs_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

adding render stats for deferred image decoding BUG=163980 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173095

Patch Set 1 #

Total comments: 2

Patch Set 2 : delete RenderingStats after it is done #

Total comments: 2

Patch Set 3 : using imageGathering instead of pixelGathering #

Patch Set 4 : clear the image decoding list when AssignGpuMemoryToTiles() is called #

Patch Set 5 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -26 lines) Patch
M cc/rendering_stats.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M cc/rendering_stats.cc View 1 2 2 chunks +15 lines, -1 line 0 comments Download
M cc/tile_manager.h View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M cc/tile_manager.cc View 1 2 3 4 8 chunks +45 lines, -24 lines 0 comments Download
M tools/perf/perf_tools/smoothness_benchmark.py View 1 2 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
qinmin
8 years ago (2012-12-13 20:05:05 UTC) #1
nduca
lgtm but rubberstampy. Please get thorough review from reveman.
8 years ago (2012-12-13 20:08:27 UTC) #2
reveman
https://codereview.chromium.org/11575015/diff/1/cc/tile_manager.cc File cc/tile_manager.cc (right): https://codereview.chromium.org/11575015/diff/1/cc/tile_manager.cc#newcode512 cc/tile_manager.cc:512: RenderingStats* stats = new RenderingStats(); you need to delete ...
8 years ago (2012-12-13 20:55:13 UTC) #3
qinmin
https://codereview.chromium.org/11575015/diff/1/cc/tile_manager.cc File cc/tile_manager.cc (right): https://codereview.chromium.org/11575015/diff/1/cc/tile_manager.cc#newcode512 cc/tile_manager.cc:512: RenderingStats* stats = new RenderingStats(); ah...I forgot that.. Done. ...
8 years ago (2012-12-13 21:09:24 UTC) #4
reveman
lgtm, but please use a better name than PixelGathering. https://codereview.chromium.org/11575015/diff/4001/cc/rendering_stats.h File cc/rendering_stats.h (right): https://codereview.chromium.org/11575015/diff/4001/cc/rendering_stats.h#newcode31 cc/rendering_stats.h:31: ...
8 years ago (2012-12-13 21:58:37 UTC) #5
qinmin
https://codereview.chromium.org/11575015/diff/4001/cc/rendering_stats.h File cc/rendering_stats.h (right): https://codereview.chromium.org/11575015/diff/4001/cc/rendering_stats.h#newcode31 cc/rendering_stats.h:31: int64 totalPixelGatheringCount; On 2012/12/13 21:58:37, David Reveman wrote: > ...
8 years ago (2012-12-13 22:42:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/11575015/6002
8 years ago (2012-12-13 23:55:37 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-14 05:14:42 UTC) #8
Message was sent while issue was closed. 
Change committed as 173095

Powered by Google App Engine
This is Rietveld 408576698