Issue 11574049: Only collect GL/D3D context specific GPUInfo in GPU process

Issue 11574049: Only collect GL/D3D context specific GPUInfo in GPU process (Closed)

Created:
8 years ago by Zhenyao Mo

Modified:
8 years ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sail+watch_chromium.org, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Only collect GL/D3D context specific GPUInfo in GPU process Instead of collecting full GPUInfo. Basic GPUInfo are already collected at Browser process startup time. This avoids sandbox issue with libpci on linux. Also, it makes GPU startup faster. BUG=162928, 165374 TEST=manual about:gpu TBR=joi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173248

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+283 lines, -347 lines)			Patch
M	content/browser/gpu/gpu_data_manager_impl.cc	View	1 2 3	4 chunks	+6 lines, -5 lines	0 comments	Download
M	content/content_tests.gypi	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/gpu/gpu_child_thread.cc	View	1 2 3	4 chunks	+1 line, -9 lines	0 comments	Download
M	content/gpu/gpu_info_collector.h	View	1 2 3	1 chunk	+19 lines, -38 lines	0 comments	Download
M	content/gpu/gpu_info_collector.cc	View	1 2 3	1 chunk	+30 lines, -18 lines	0 comments	Download
M	content/gpu/gpu_info_collector_android.cc	View	1 2 3	1 chunk	+7 lines, -6 lines	0 comments	Download
M	content/gpu/gpu_info_collector_linux.cc	View	1 2 3	3 chunks	+73 lines, -69 lines	0 comments	Download
M	content/gpu/gpu_info_collector_mac.mm	View	1 2 3	4 chunks	+7 lines, -7 lines	0 comments	Download
D	content/gpu/gpu_info_collector_unittest_win.cc	View	1 2 3	1 chunk	+0 lines, -56 lines	0 comments	Download
M	content/gpu/gpu_info_collector_win.cc	View	1 2 3	6 chunks	+134 lines, -126 lines	0 comments	Download
M	content/gpu/gpu_main.cc	View	1 2 3	1 chunk	+5 lines, -7 lines	0 comments	Download
M	content/public/common/content_switches.h	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View	1 2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/test/gpu/gpu_test_config.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Zhenyao Mo

I removed content/gpu/gpu_info_collector_unittest_win.cc sp we don't have to expose CollectGraphicsInfoD3D just for testing purpose, especially ...

8 years ago (2012-12-14 22:37:21 UTC) #2

Ken Russell (switch to Gerrit)

LGTM if this has been tested. Do you foresee any issues with automatic graphics switching ...

8 years ago (2012-12-15 00:33:56 UTC) #3

Zhenyao Mo

8 years ago (2012-12-15 00:38:13 UTC) #4

On 2012/12/15 00:33:56, kbr wrote:
> LGTM if this has been tested.
> 
> Do you foresee any issues with automatic graphics switching on Mac OS?

There shouldn't be any issues.

> 
>
https://codereview.chromium.org/11574049/diff/3004/content/gpu/gpu_child_thre...
> File content/gpu/gpu_child_thread.cc (right):
> 
>
https://codereview.chromium.org/11574049/diff/3004/content/gpu/gpu_child_thre...
> content/gpu/gpu_child_thread.cc:167: // in GpuMain() and passed down to
> GpuChildThread.
> Is this comment still relevant?

Removed.

> 
>
https://codereview.chromium.org/11574049/diff/3004/content/gpu/gpu_info_colle...
> File content/gpu/gpu_info_collector.cc (right):
> 
>
https://codereview.chromium.org/11574049/diff/3004/content/gpu/gpu_info_colle...
> content/gpu/gpu_info_collector.cc:97: gpu_info->gl_extensions
> =GetGLString(GL_EXTENSIONS);
> space after '='.

Done.

Expand Messages | Collapse Messages