Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11574034: [filemanager] Fix startup initialization: set current root dir before updating roots. (Closed)

Created:
8 years ago by dgozman
Modified:
8 years ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

[filemanager] Fix startup initialization: set current root dir before updating roots. BUG=164274 TEST=See bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173337

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/file_manager/js/directory_model.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
dgozman
Take a look, please. Before, |updateRootsListSelection_| caused changing directory to the not-yet-updated |currentDirByRoot_|.
8 years ago (2012-12-14 12:40:04 UTC) #1
Vladislav Kaznacheev
lgtm
8 years ago (2012-12-14 12:55:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/11574034/1
8 years ago (2012-12-14 13:14:34 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-14 15:48:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/11574034/1
8 years ago (2012-12-14 16:16:52 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-14 20:32:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/11574034/1
8 years ago (2012-12-15 10:54:20 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-15 18:20:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/11574034/1
8 years ago (2012-12-15 20:34:59 UTC) #9
commit-bot: I haz the power
8 years ago (2012-12-15 22:40:59 UTC) #10
Message was sent while issue was closed. 
Change committed as 173337

Powered by Google App Engine
This is Rietveld 408576698