cc: Add some more infrastructure for two trees

cc: Add some more infrastructure for two trees

PictureLayerImpl gets the ability to sync a tiling from active
to pending tree when it gets created so that layers can share tiles.
A few functions are added to make this possible.

BUG=155209
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173366

[enne (OOO), 2012-12-14 02:05:06]

This is a little bit of an incremental patch.  I wanted to add some hooks to
LayerTreeHostImpl/LayerTreeImpl, even though a lot of them aren't quite used
yet.

The next step is to do a tree synchronization to the pending tree and actually
create it.

[nduca, 2012-12-14 02:18:42]

https://codereview.chromium.org/11574026/diff/1009/cc/layer_tree_impl.h
File cc/layer_tree_impl.h (right):

https://codereview.chromium.org/11574026/diff/1009/cc/layer_tree_impl.h#newco...
cc/layer_tree_impl.h:52: LayerImpl* ActiveTreeLayerById(int id);
Get or FindActiveTreeLayerByBlah

https://codereview.chromium.org/11574026/diff/1009/cc/picture_layer.cc
File cc/picture_layer.cc (right):

https://codereview.chromium.org/11574026/diff/1009/cc/picture_layer.cc#newcode48
cc/picture_layer.cc:48: if (drawsContent()) {
can this be a method on the picture layer impl? DidSyncFromPendingTree? This
would allow us to build unit tests for this subsystem without having to
instantiate the main thread side layer.

[enne (OOO), 2012-12-14 17:30:53]

https://codereview.chromium.org/11574026/diff/1009/cc/layer_tree_impl.h
File cc/layer_tree_impl.h (right):

https://codereview.chromium.org/11574026/diff/1009/cc/layer_tree_impl.h#newco...
cc/layer_tree_impl.h:52: LayerImpl* ActiveTreeLayerById(int id);
On 2012/12/14 02:18:43, nduca wrote:
> Get or FindActiveTreeLayerByBlah

Ok, sure.  FindActiveTreeLayerByBlah, it is.

https://codereview.chromium.org/11574026/diff/1009/cc/picture_layer.cc
File cc/picture_layer.cc (right):

https://codereview.chromium.org/11574026/diff/1009/cc/picture_layer.cc#newcode48
cc/picture_layer.cc:48: if (drawsContent()) {
On 2012/12/14 02:18:43, nduca wrote:
> can this be a method on the picture layer impl? DidSyncFromPendingTree? This
> would allow us to build unit tests for this subsystem without having to
> instantiate the main thread side layer.

Do you mean without having to instantiate an active tree with this layer?

Are you saying that this should set some needs-to-sync flag on the
PictureLayerImpl and the first update that it does does a sync from the other
layer?

[nduca, 2012-12-14 18:42:10]

> Do you mean without having to instantiate an active tree with this layer?
I was meaning that if you could move this block of code to the picture layer
impl so we could get test coverage of it without having to instance a picture
layer.

> Are you saying that this should set some needs-to-sync flag on the
> PictureLayerImpl and the first update that it does does a sync from the other
> layer?
Naw, we could just call imediately?Mainly a testing idea... its cool if it
doesnt make sense.

[enne (OOO), 2012-12-14 18:56:56]

Ah, gotcha.  I moved SyncFromActiveLayer() to PictureLayerImpl.  PTAL.

[nduca, 2012-12-14 20:01:26]

lgtmnomnomnom

[commit-bot: I haz the power, 2012-12-14 20:51:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/11574026/12001

[commit-bot: I haz the power, 2012-12-15 02:21:12]

Retried try job too often on win_rel for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-16 00:51:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/11574026/14001

[commit-bot: I haz the power, 2012-12-16 04:53:11]

Change committed as 173366