Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 11574008: Disable ash tests on Windows that rely on multiple displays or display resizing (Closed)

Created:
8 years ago by scottmg
Modified:
8 years ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Disable ash tests on Windows that rely on multiple displays or display resizing Metro-style apps are specifically designed not to span multiple displays, so these tests don't make any sense (ref: http://blogs.msdn.com/b/b8/archive/2012/05/21/enhancing-windows-8-for-multiple-monitors.aspx) and fail running on win8. R=ben@chromium.org BUG=165962, 154081 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173544

Patch Set 1 #

Patch Set 2 : more disabling for multi-display tests #

Patch Set 3 : remove other workspace resizers #

Total comments: 1

Patch Set 4 : disable a few tests that rely on non-fullscreen display/rootwindow #

Patch Set 5 : remove unrelated change #

Patch Set 6 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -10 lines) Patch
M ash/ash.gyp View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M ash/display/display_controller_unittest.cc View 1 1 chunk +10 lines, -1 line 0 comments Download
M ash/display/mouse_cursor_event_filter_unittest.cc View 5 chunks +44 lines, -5 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 2 3 5 chunks +29 lines, -4 lines 0 comments Download
M ui/aura/remote_root_window_host_win.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
scottmg
8 years ago (2012-12-13 18:52:21 UTC) #1
Ben Goodger (Google)
+sky https://codereview.chromium.org/11574008/diff/3005/ash/ash.gyp File ash/ash.gyp (right): https://codereview.chromium.org/11574008/diff/3005/ash/ash.gyp#newcode613 ash/ash.gyp:613: # Workspace can't be resized on Win Ash. ...
8 years ago (2012-12-13 21:44:29 UTC) #2
scottmg
On 2012/12/13 21:44:29, Ben Goodger (Google) wrote: > +sky > > https://codereview.chromium.org/11574008/diff/3005/ash/ash.gyp > File ash/ash.gyp ...
8 years ago (2012-12-13 21:48:44 UTC) #3
scottmg
On 2012/12/13 21:48:44, scottmg wrote: > On 2012/12/13 21:44:29, Ben Goodger (Google) wrote: > > ...
8 years ago (2012-12-13 21:51:45 UTC) #4
sky
On Thu, Dec 13, 2012 at 1:48 PM, <scottmg@chromium.org> wrote: > On 2012/12/13 21:44:29, Ben ...
8 years ago (2012-12-13 22:57:41 UTC) #5
scottmg
On 2012/12/13 22:57:41, sky wrote: > On Thu, Dec 13, 2012 at 1:48 PM, <mailto:scottmg@chromium.org> ...
8 years ago (2012-12-15 00:44:51 UTC) #6
sky
LGTM
8 years ago (2012-12-15 22:24:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11574008/5017
8 years ago (2012-12-17 19:18:33 UTC) #8
commit-bot: I haz the power
8 years ago (2012-12-17 21:57:35 UTC) #9
Message was sent while issue was closed.
Change committed as 173544

Powered by Google App Engine
This is Rietveld 408576698