Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 11574003: Fix Android ContentShell's incorrect behavior when opening link with window.open. (Closed)

Created:
8 years ago by Shouqun Liu
Modified:
8 years ago
Reviewers:
Ted C, Yaron, Jay Civelli
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix Android ContentShell's incorrect behavior when opening link with window.open. Fixed the two following issues: - When open a link with 'window.open', new shell content is not rendered correctly, the content is always DEFAULT_SHELL_URL(http://www.google.com). - When ContentShell activity is stopped and restarted, the rendered content is clear and reload to DEFAULT_SHELL_URL. BUG=165745 TEST=manual: verified link in news.google.com is opened and rendered correctly Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173370

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/shell/android/java/src/org/chromium/content_shell/ShellManager.java View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Shouqun Liu
When open a link with "window.open" or stop/restart the shell activity, the rendered content is ...
8 years ago (2012-12-13 08:41:41 UTC) #1
Jay Civelli
https://codereview.chromium.org/11574003/diff/1/content/shell/android/java/src/org/chromium/content_shell/ShellManager.java File content/shell/android/java/src/org/chromium/content_shell/ShellManager.java (right): https://codereview.chromium.org/11574003/diff/1/content/shell/android/java/src/org/chromium/content_shell/ShellManager.java#newcode44 content/shell/android/java/src/org/chromium/content_shell/ShellManager.java:44: sStartup = false; would be clearer.
8 years ago (2012-12-13 18:12:24 UTC) #2
Shouqun Liu
On 2012/12/13 18:12:24, Jay Civelli wrote: > https://codereview.chromium.org/11574003/diff/1/content/shell/android/java/src/org/chromium/content_shell/ShellManager.java > File content/shell/android/java/src/org/chromium/content_shell/ShellManager.java > (right): > > ...
8 years ago (2012-12-14 00:30:44 UTC) #3
Jay Civelli
LGTM, Ted should probably review as well.
8 years ago (2012-12-14 16:58:23 UTC) #4
Ted C
lgtm
8 years ago (2012-12-14 17:00:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/11574003/3
8 years ago (2012-12-15 03:39:07 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-15 08:00:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/11574003/3
8 years ago (2012-12-15 09:30:45 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-15 12:55:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/11574003/3
8 years ago (2012-12-15 15:04:14 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-15 18:15:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/11574003/3
8 years ago (2012-12-16 02:07:23 UTC) #12
commit-bot: I haz the power
8 years ago (2012-12-16 05:13:45 UTC) #13
Message was sent while issue was closed.
Change committed as 173370

Powered by Google App Engine
This is Rietveld 408576698