Issue 11573069: [cc] Fold more update calls into updateDrawProperties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11573069: [cc] Fold more update calls into updateDrawProperties (Closed)

Created:
8 years ago by nduca

Modified:
8 years ago

Reviewers:

CC:
chromium-reviews, cc-bugs_chromium.org, enne (OOO)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[cc] Fold more update calls into updateDrawProperties (Reland of https://codereview.chromium.org/11529006/) Now that we have a clean update system, we can remove the manual calling of updateRootScrollLayerImplTransform and other similar kinds of "I'm going to do something manually in a half dozen places because I can." This removes some surface area on LTHI which helps with the LTHI->LTI push. BUG=155209 TBR=enne Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173820

Patch Set 1 #

Patch Set 2 : rebase #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -78 lines)			Patch
M	cc/layer_impl_unittest.cc	View		5 chunks	+6 lines, -3 lines	0 comments	Download
M	cc/layer_tree_host_impl.h	View	1	4 chunks	+8 lines, -12 lines	0 comments	Download
M	cc/layer_tree_host_impl.cc	View	1	5 chunks	+9 lines, -36 lines	0 comments	Download
M	cc/layer_tree_host_impl_unittest.cc	View	1	16 chunks	+39 lines, -23 lines	0 comments	Download
M	cc/layer_tree_host_unittest.cc	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	cc/test/fake_layer_tree_host_impl.h	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	cc/test/layer_tree_test_common.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/11573069/3002

8 years ago (2012-12-18 19:41:57 UTC) #2

Message was sent while issue was closed.

Change committed as 173820

Expand Messages | Collapse Messages