[Media Galleries] Move RemovableStorageInfo notifications to chrome namespace (part 2)

chrome/browser/system_monitor/test_removable_storage_notifications.h

Index: chrome/browser/system_monitor/test_removable_storage_notifications.h
diff --git a/chrome/browser/system_monitor/test_removable_storage_notifications.h b/chrome/browser/system_monitor/test_removable_storage_notifications.h
new file mode 100644
index 0000000000000000000000000000000000000000..bb8c0b8ef985c4b45b0c5e28a169d62e1153fb07
--- /dev/null
+++ b/chrome/browser/system_monitor/test_removable_storage_notifications.h
@@ -0,0 +1,38 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SYSTEM_MONITOR_TEST_REMOVABLE_STORAGE_NOTIFICATIONS_H_
+#define CHROME_BROWSER_SYSTEM_MONITOR_TEST_REMOVABLE_STORAGE_NOTIFICATIONS_H_
+
+#include "chrome/browser/system_monitor/removable_storage_notifications.h"
+
+namespace chrome {
+namespace test {

[vandebo (ex-Chrome), 2013/01/24 19:19:10]

I don't often see the use of namespace test, are you copying this from
somewhere?

[Greg Billock, 2013/01/24 20:46:03]

All the other test_* files in this package use this idiom. Just trying to blend
in... :-)

On 2013/01/24 19:19:10, vandebo wrote:

[vandebo (ex-Chrome), 2013/01/24 23:39:01]

grep "namespace t" `find chrome/browser -name "test_*"` finds no real matches...

[Greg Billock, 2013/01/25 20:01:21]

http://code.google.com/p/chromium/source/search?q=namespace+test+file%3Achrom...

I'm happy to get rid of it; I just don't think it matters.

[vandebo (ex-Chrome), 2013/01/26 01:00:21]

It's fine, I was just trying to understand best practices.

[Greg Billock, 2013/01/26 01:42:07]

no worries. I'm not necessarily claiming it as best practices. :-) I think it's
fine to have this convention in this module, but I don't think it is uniform...

On 2013/01/26 01:00:21, vandebo wrote:

+
+// Needed to set up the RemovableStorageNotifications singleton (done in
+// the base class).
+class TestRemovableStorageNotifications
+    : public chrome::RemovableStorageNotifications {
+ public:
+  TestRemovableStorageNotifications();
+  virtual ~TestRemovableStorageNotifications();
+
+  virtual bool GetDeviceInfoForPath(
+      const FilePath& path,
+      StorageInfo* device_info) const OVERRIDE;
+
+  virtual uint64 GetStorageSize(const std::string& location) const OVERRIDE;
+
+#if defined(OS_WIN)
+  virtual bool GetMTPStorageInfoFromDeviceId(
+      const std::string& storage_device_id,
+      string16* device_location,
+      string16* storage_object_id) const OVERRIDE;
+};
+#endif
+
+}  // namespace test
+}  // namespace chrome
+
+#endif  // CHROME_BROWSER_SYSTEM_MONITOR_TEST_REMOVABLE_STORAGE_NOTIFICATIONS_H_