Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 11573019: cc: Fix a number of tests that need content bounds (Closed)

Created:
8 years ago by enne (OOO)
Modified:
8 years ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org, shawnsingh
Visibility:
Public.

Description

cc: Fix a number of tests that need content bounds Many cc tests don't call calcDrawProperties and so would have incorrect content bounds on layers if didUpdateBounds were to be removed. This patch does not address all of the tests broken by removing that function, but fixes a large number of them. R=danakj@chromium.org BUG=166023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173390

Patch Set 1 #

Patch Set 2 : Remove solid color and tiled layer changes #

Patch Set 3 : Only touch one file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M cc/layer_tree_host_unittest.cc View 1 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
enne (OOO)
8 years ago (2012-12-13 21:50:40 UTC) #1
danakj
I like the LTH test changes, but for solid color and tiled layer, I think ...
8 years ago (2012-12-14 23:06:25 UTC) #2
enne (OOO)
Rebased, and just removed solid color layer changes and tiled layer changes. I agree that ...
8 years ago (2012-12-14 23:20:12 UTC) #3
danakj
LGTM
8 years ago (2012-12-14 23:22:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11573019/7001
8 years ago (2012-12-16 17:49:18 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-16 20:31:41 UTC) #6
Message was sent while issue was closed.
Change committed as 173390

Powered by Google App Engine
This is Rietveld 408576698