Issue 11573017: MIPS: Improve array to string conversion.

Issue 11573017: MIPS: Improve array to string conversion. (Closed)

Created:
8 years ago by palfia

Modified:
8 years ago

Reviewers:
kisg, Paul Lind, danno, Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Improve array to string conversion. Port r13144 (71c45300) BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=13230

Patch Set 2 : Use SmiUntag & cleanup #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -0 lines)			Patch
M	src/mips/codegen-mips.cc	View	1	1 chunk	+44 lines, -0 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View		1 chunk	+32 lines, -0 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/mips/lithium-mips.h	View		2 chunks	+25 lines, -0 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM, but please address comments before I land this CL. https://codereview.chromium.org/11573017/diff/1/src/mips/codegen-mips.cc File src/mips/codegen-mips.cc (right): https://codereview.chromium.org/11573017/diff/1/src/mips/codegen-mips.cc#newcode550 ...

8 years ago (2012-12-17 10:27:26 UTC) #2

palfia

Thanks for the review, I've addressed your comments and I've also cleaned up the code ...

8 years ago (2012-12-17 18:46:55 UTC) #3

Yang

8 years ago (2012-12-18 09:14:16 UTC) #4

On 2012/12/17 18:46:55, palfia wrote:
> Thanks for the review, I've addressed your comments and I've also cleaned up
the
> code a bit.
> 
> https://codereview.chromium.org/11573017/diff/1/src/mips/codegen-mips.cc
> File src/mips/codegen-mips.cc (right):
> 
>
https://codereview.chromium.org/11573017/diff/1/src/mips/codegen-mips.cc#newc...
> src/mips/codegen-mips.cc:550: // Smis are tagged by left shift by 1, thus LSR
by
> 1 to smi-untag inline.
> On 2012/12/17 10:27:26, Yang wrote:
> > This comment does not apply to MIPS.
> 
> Done.
> 
>
https://codereview.chromium.org/11573017/diff/1/src/mips/codegen-mips.cc#newc...
> src/mips/codegen-mips.cc:551: __ srl(at, index, 1);
> On 2012/12/17 10:27:26, Yang wrote:
> > Isn't there a SmiUntag macro for MIPS as well?
> 
> Done.

LGTM, landing.

Expand Messages | Collapse Messages