Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11573015: Create abstract common base class for impl scrollbars. (Closed)

Created:
8 years ago by wjmaclean
Modified:
8 years ago
Reviewers:
jamesr1, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Create abstract common base class for impl scrollbars. BUG=None NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173466

Patch Set 1 #

Patch Set 2 : Rename base class. #

Patch Set 3 : Rename base class. #

Patch Set 4 : So that's what CC_EXPORT is for. #

Patch Set 5 : Rebased for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -8 lines) Patch
M cc/cc.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M cc/scrollbar_layer_impl.h View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M cc/scrollbar_layer_impl.cc View 1 2 3 4 2 chunks +21 lines, -1 line 0 comments Download
A cc/scrollbar_layer_impl_base.h View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
wjmaclean
Does this look reasonable? It contains everything I'd need to make a suitable pinch-zoom scrollbar ...
8 years ago (2012-12-13 20:02:00 UTC) #1
wjmaclean
On 2012/12/13 20:02:00, wjmaclean wrote: > Does this look reasonable? It contains everything I'd need ...
8 years ago (2012-12-13 20:17:36 UTC) #2
jamesr1
On Thu, Dec 13, 2012 at 12:17 PM, <wjmaclean@chromium.org> wrote: > On 2012/12/13 20:02:00, wjmaclean ...
8 years ago (2012-12-13 20:37:17 UTC) #3
wjmaclean
On 2012/12/13 20:37:17, jamesr1 wrote: > On Thu, Dec 13, 2012 at 12:17 PM, <mailto:wjmaclean@chromium.org> ...
8 years ago (2012-12-13 21:18:22 UTC) #4
wjmaclean
Here's the re-named base class. PTAL.
8 years ago (2012-12-14 18:21:37 UTC) #5
enne (OOO)
lgtm, although it looks like the patch you uploaded was a diff against your previous ...
8 years ago (2012-12-14 18:28:54 UTC) #6
wjmaclean
On 2012/12/14 18:28:54, enne wrote: > lgtm, although it looks like the patch you uploaded ...
8 years ago (2012-12-14 18:36:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/11573015/2003
8 years ago (2012-12-14 18:46:41 UTC) #8
commit-bot: I haz the power
Failed to trigger a try job on win_rel HTTP Error 400: Bad Request
8 years ago (2012-12-14 19:58:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/11573015/1008
8 years ago (2012-12-14 19:58:23 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-14 23:02:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/11573015/1008
8 years ago (2012-12-15 01:23:26 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-15 05:18:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/11573015/24001
8 years ago (2012-12-17 14:56:25 UTC) #14
commit-bot: I haz the power
8 years ago (2012-12-17 15:12:38 UTC) #15
Message was sent while issue was closed. 
Change committed as 173466

Powered by Google App Engine
This is Rietveld 408576698