Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 11573009: Reenable GeolocationBrowserTest.NoInfoBarBeforeStart (Closed)

Created:
8 years ago by John Knottenbelt
Modified:
7 years, 11 months ago
Reviewers:
bulach
CC:
chromium-reviews
Visibility:
Public.

Description

Reenable GeolocationBrowserTest.NoInfoBarBeforeStart This test was crashy on Windows, but the call stack was insufficient to diagnose. As there have been some infobar refactorings since this test was disabled, let's reenable it. TEST=GeolocationBrowserTest.NoInfoBarBeforeStart BUG=66400 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
John Knottenbelt
8 years ago (2012-12-13 17:50:53 UTC) #1
bulach
lgtm, thanks!
8 years ago (2012-12-13 17:52:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/11573009/1
7 years, 11 months ago (2013-01-09 12:28:35 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 15:55:41 UTC) #4
Message was sent while issue was closed.
Change committed as 175805

Powered by Google App Engine
This is Rietveld 408576698