Telemetry: More elegant histogram printing.

build/android/pylib/perf_tests_helper.py

Index: build/android/pylib/perf_tests_helper.py
diff --git a/build/android/pylib/perf_tests_helper.py b/build/android/pylib/perf_tests_helper.py
index 68a707f8c6a42f7840e940f5c55ff496fc12c722..7b2ac1f582326ed9ba01747554667b9b8de92891 100644
--- a/build/android/pylib/perf_tests_helper.py
+++ b/build/android/pylib/perf_tests_helper.py
@@ -103,23 +103,17 @@ def PrintPerfResult(measurement, trace, values, units, result_type='default',
   else:
     assert(result_type in ['histogram', 'unimportant-histogram'])
     assert isinstance(values, list)
-    assert len(values)
-    # Print out each histogram separately. We can't print the units, otherwise
-    # the histogram json output can't be parsed easily.
-    output = ''
-    ix = 1
-    for value in values:
-      name = '%s.%s_%d' % (_EscapePerfResult(measurement), trace_name, ix)
-      output += '%s%s%s : %s = %s' % (
-          '\n' if ix > 1 else '',
-          RESULT_TYPES[result_type],
-          name,
-          name,
-          value)
-      ix += 1
-    measurement = '%s.%s' % (measurement, trace_name)
-    means_and_sds = [GeomMeanAndStdDevFromHistogram(value) for value in values]
-    _, avg, sd = _MeanAndStdDevFromList([mean for (mean, _) in means_and_sds ])
+    # The histograms can only be printed out one by one, and we don't compute
+    # average information from them.

[bulach, 2012/12/13 18:21:59]

sorry, not sure I follow :) isn't 116 computing avg?
perhaps it'd be clearer as something like:
# The histograms can only be printed individually, there's
# no computation across different histograms.

(but then again, I may have completely misunderstood this..)

[marja, 2012/12/13 18:31:42]

Your comment was what I meant exactly. So we don't compute anything from a list
of histograms, but we compute averages from a single histogram.

-> Changed the comment to what you suggested.

+    assert len(values) == 1
+    value = values[0]
+    measurement = measurement + '.' + trace_name

[bulach, 2012/12/13 18:21:59]

nit: measurement += '.' + trace_name

[marja, 2012/12/13 18:31:42]

Done.

+    output = '%s%s: %s=%s' % (
+        RESULT_TYPES[result_type],
+        _EscapePerfResult(measurement),
+        _EscapePerfResult(measurement),
+        value)
+    avg, sd = GeomMeanAndStdDevFromHistogram(value)
 
   if avg:
     output += '\nAvg %s: %f%s' % (measurement, avg, units)