Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 11572060: Improve CertVerifyProcOpenSSL robustness against malicious data (Closed)

Created:
8 years ago by ppi
Modified:
8 years ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Improve CertVerifyProcOpenSSL robustness against malicious data This patch allows OpenSSL certificate verification to fail gracefully when preliminary initialization step fails, rather than crashing the browser. BUG=165858 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173459

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M net/base/cert_verify_proc_openssl.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ppi
Could you have a look, Ryan? This fixes an issue you pointed out in https://codereview.chromium.org/11549033/diff/2001/net/base/cert_verify_proc_openssl.cc ...
8 years ago (2012-12-17 10:50:21 UTC) #1
Ryan Sleevi
lgtm
8 years ago (2012-12-17 11:03:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/11572060/5001
8 years ago (2012-12-17 11:03:49 UTC) #3
commit-bot: I haz the power
8 years ago (2012-12-17 15:02:06 UTC) #4
Message was sent while issue was closed.
Change committed as 173459

Powered by Google App Engine
This is Rietveld 408576698