Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 11571050: Avoid PNG encode/decode for Win8 tile logo creation (Closed)

Created:
8 years ago by James Cook
Modified:
7 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Avoid PNG encode/decode for Win8 tile logo creation Use the SkBitmap version of CalculateKMeanColorOfBitmap() to avoid a PNG encode/decode round trip. BUG=none TEST=cpu says it looks OK on his Win8 machine Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175430

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -28 lines) Patch
M chrome/browser/ui/metro_pin_tab_helper_win.cc View 1 2 chunks +6 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
James Cook
cpu, can you try this patch on Win8 and see if the tiles it creates ...
8 years ago (2012-12-19 05:12:55 UTC) #1
cpu_(ooo_6.6-7.5)
ok. Give me a couple of hours.
8 years ago (2012-12-19 19:33:32 UTC) #2
James Cook
On 2012/12/19 19:33:32, cpu wrote: > ok. Give me a couple of hours. Friendly ping?
8 years ago (2012-12-20 18:04:48 UTC) #3
James Cook
Ben, PTAL. cpu@ tried it on his Win8 box and says the colors look fine.
7 years, 11 months ago (2013-01-07 18:46:38 UTC) #4
Ben Goodger (Google)
lgtm
7 years, 11 months ago (2013-01-07 21:18:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/11571050/8001
7 years, 11 months ago (2013-01-07 21:46:47 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 00:34:27 UTC) #7
Message was sent while issue was closed.
Change committed as 175430

Powered by Google App Engine
This is Rietveld 408576698