Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 11571032: [NaCl SDK] cleanup python unittests (Closed)

Created:
8 years ago by Sam Clegg
Modified:
8 years ago
Reviewers:
binji
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

[NaCl SDK] Cleanup python unit tests. Python unit tests file should ends with _test.py rather than start with test_. Run zip tests and generate_make rate_make tests as part of test_all.py Remove two old test cases from generate_make tests. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173306

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -1538 lines) Patch
A + native_client_sdk/src/build_tools/tests/generate_make_test.py View 1 1 chunk +0 lines, -10 lines 0 comments Download
A + native_client_sdk/src/build_tools/tests/sdktools_commands_test.py View 1 1 chunk +1 line, -1 line 0 comments Download
A + native_client_sdk/src/build_tools/tests/sdktools_test.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M native_client_sdk/src/build_tools/tests/test_all.py View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
D native_client_sdk/src/build_tools/tests/test_generate_make.py View 1 1 chunk +0 lines, -124 lines 0 comments Download
D native_client_sdk/src/build_tools/tests/test_sdktools.py View 1 1 chunk +0 lines, -230 lines 0 comments Download
D native_client_sdk/src/build_tools/tests/test_sdktools_commands.py View 1 1 chunk +0 lines, -227 lines 0 comments Download
D native_client_sdk/src/build_tools/tests/test_update_nacl_manifest.py View 1 1 chunk +0 lines, -641 lines 0 comments Download
A + native_client_sdk/src/build_tools/tests/update_nacl_manifest_test.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M native_client_sdk/src/tools/create_nmf.py View 1 2 6 chunks +61 lines, -4 lines 0 comments Download
A native_client_sdk/src/tools/quote.py View 1 2 1 chunk +190 lines, -0 lines 0 comments Download
A + native_client_sdk/src/tools/tests/httpd_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/tools/tests/oshelpers_test.py View 3 chunks +7 lines, -2 lines 0 comments Download
D native_client_sdk/src/tools/tests/test_httpd.py View 1 chunk +0 lines, -111 lines 0 comments Download
D native_client_sdk/src/tools/zip_test.py View 1 chunk +0 lines, -186 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sam Clegg
8 years ago (2012-12-14 23:10:48 UTC) #1
binji
lgtm, thanks! https://codereview.chromium.org/11571032/diff/4001/native_client_sdk/src/build_tools/tests/test_all.py File native_client_sdk/src/build_tools/tests/test_all.py (right): https://codereview.chromium.org/11571032/diff/4001/native_client_sdk/src/build_tools/tests/test_all.py#newcode13 native_client_sdk/src/build_tools/tests/test_all.py:13: #sys.path.append(os.path.join(SDK_DIR, 'tools')) remove unused code
8 years ago (2012-12-14 23:13:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/11571032/5014
8 years ago (2012-12-14 23:26:11 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-15 04:25:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/11571032/5014
8 years ago (2012-12-15 16:10:02 UTC) #5
commit-bot: I haz the power
Change committed as 173306
8 years ago (2012-12-15 20:07:19 UTC) #6
bsy
8 years ago (2012-12-18 00:07:34 UTC) #7
Message was sent while issue was closed.
this CL accidentally included https://codereview.chromium.org/11547009/ (which
had an l.g.t.m. already but had some [verbal] cleanup suggestions planned).  the
cleanup for that CL continues in https://codereview.chromium.org/11624005/

Powered by Google App Engine
This is Rietveld 408576698