Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 11571023: Move ash/wm's DialogFrameView to ui/views/window; etc. (Closed)

Created:
8 years ago by msw
Modified:
8 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org, Mike Wittman, Ben Goodger (Google)
Visibility:
Public.

Description

Move ash/wm's DialogFrameView to ui/views/window; etc. Move ash/wm/dialog_frame_view.[h|cc] to ui/views/window/. Move DialogFrameView to views namespace; export; cleanup. Expose static DialogDelegate::UseNewStyle() for commandline flag. OVERRIDE DialogDelegate::CreateNonClientFrameView to use DialogFrameView with flag. OVERRIDE DialogDelegateView::GetContentsView to return |this|. (nix redundant GetContentsView() OVERRIDEs from subclasses) Cleanup DialogClientView ctor; encapsulate StyleParams struct. Rewrite WidgetExample; nix transparency, add dialog widget, consolidate. BUG=166075 TEST=views_examples WidgetExample changes with --enabled-new-dialog-style R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173993

Patch Set 1 #

Patch Set 2 : Fix example; rename some ChromeStyle to NewStyle; expose static UseNewStyle; encapsulate StyleParam… #

Patch Set 3 : Rebase; rewrite WidgetExample; remove dialog_frame_view.cc|h from ash.gyp. #

Patch Set 4 : Remove redundant GetContentsView() OVERRIDEs; re-git-add dialog_frame_view files. #

Total comments: 2

Patch Set 5 : Reorder DialogDelegate functions; inline Get*Params into WidgetExample::ButtonPressed; etc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -580 lines) Patch
M ash/ash.gyp View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M ash/display/display_error_dialog.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ash/display/display_error_dialog.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M ash/shell.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
D ash/wm/dialog_frame_view.h View 1 2 1 chunk +0 lines, -67 lines 0 comments Download
D ash/wm/dialog_frame_view.cc View 1 2 1 chunk +0 lines, -193 lines 0 comments Download
M chrome/browser/chromeos/enrollment_dialog_view.cc View 1 2 3 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/password_changed_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/password_changed_view.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/options/network_config_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/ui/idle_logout_dialog_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/ui/idle_logout_dialog_view.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/about_ipc_dialog.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/about_ipc_dialog.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/crypto_module_password_dialog_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/crypto_module_password_dialog_view.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/edit_search_engine_dialog.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/edit_search_engine_dialog.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/importer/import_lock_dialog_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/importer/import_lock_dialog_view.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/importer/import_progress_dialog_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/importer/import_progress_dialog_view.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/uninstall_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/uninstall_view.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/examples/widget_example.h View 1 2 3 4 2 chunks +9 lines, -13 lines 0 comments Download
M ui/views/examples/widget_example.cc View 1 2 3 4 3 chunks +27 lines, -112 lines 0 comments Download
M ui/views/views.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/window/dialog_client_view.h View 1 3 chunks +12 lines, -18 lines 0 comments Download
M ui/views/window/dialog_client_view.cc View 1 2 3 5 chunks +20 lines, -27 lines 0 comments Download
M ui/views/window/dialog_delegate.h View 1 2 3 4 5 chunks +7 lines, -8 lines 0 comments Download
M ui/views/window/dialog_delegate.cc View 1 2 3 4 4 chunks +23 lines, -10 lines 0 comments Download
A + ui/views/window/dialog_frame_view.h View 1 2 3 5 chunks +11 lines, -16 lines 0 comments Download
A + ui/views/window/dialog_frame_view.cc View 1 2 3 7 chunks +14 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
msw
Hey Scott, please take a look; thanks! The change is a smaller than it looks ...
8 years ago (2012-12-19 03:38:30 UTC) #1
sky
LGTM https://codereview.chromium.org/11571023/diff/17062/ui/views/window/dialog_delegate.h File ui/views/window/dialog_delegate.h (right): https://codereview.chromium.org/11571023/diff/17062/ui/views/window/dialog_delegate.h#newcode32 ui/views/window/dialog_delegate.h:32: static bool UseNewStyle(); constructor/destructor before other methods.
8 years ago (2012-12-19 15:55:54 UTC) #2
msw
Done; I also inlined Get*Params into WidgetExample::ButtonPressed and updated some comments; landing. https://codereview.chromium.org/11571023/diff/17062/ui/views/window/dialog_delegate.h File ui/views/window/dialog_delegate.h ...
8 years ago (2012-12-19 17:07:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/11571023/15002
8 years ago (2012-12-19 17:07:47 UTC) #4
commit-bot: I haz the power
8 years ago (2012-12-19 21:41:41 UTC) #5
Message was sent while issue was closed.
Change committed as 173993

Powered by Google App Engine
This is Rietveld 408576698