Issue 11570061: Hardfloat does not imply VFPv3, only VFPv2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11570061: Hardfloat does not imply VFPv3, only VFPv2. (Closed)

Created:
8 years ago by Yang

Modified:
8 years ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Hardfloat does not imply VFPv3, only VFPv2. Raspberry Pi is an example. BUG=v8:2393 Committed: https://code.google.com/p/v8/source/detail?r=13232

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

Patch contributed by Chi-Thanh Christopher Nguyen <nguyenchithanh@gmail.com>, LGTM.

8 years ago (2012-12-18 09:31:56 UTC) #1

ulan_google

8 years ago (2012-12-18 09:47:45 UTC) #2

On 2012/12/18 09:31:56, Yang wrote:
> Patch contributed by Chi-Thanh Christopher Nguyen
<mailto:nguyenchithanh@gmail.com>,
> LGTM.

LGTM. CAN_USE_VFP3_INSTRUCTIONS flag computation was fixed in r13175, so this
change is safe for ChromeOS.

Expand Messages | Collapse Messages