Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 11570058: Fix PepperView to let PPAPI up-scale on high-DPI devices where possible. (Closed)

Created:
8 years ago by Wez
Modified:
8 years ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Fix PepperView to let PPAPI up-scale on high-DPI devices where possible. Previously PepperView would always render at device resolution, requiring the Chromoting video decode pipeline to up- or down-scale as necessary. This CL lets PPAPI up-scale for high-DPI if the plugin's logical dimensions match those of the source, both reducing Chromoting's rendering overhead in and improving output quality for this case. BUG=163228 TEST=Connect to a host from a high-DPI client and verify that monochrome, un-anti-aliased text displayed at the host is lovely and crisp and readable. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173807

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M remoting/client/plugin/pepper_view.cc View 1 chunk +18 lines, -5 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Wez
PTAL
8 years ago (2012-12-18 04:45:03 UTC) #1
Jamie
lgtm https://chromiumcodereview.appspot.com/11570058/diff/1/remoting/client/plugin/pepper_view.cc File remoting/client/plugin/pepper_view.cc (left): https://chromiumcodereview.appspot.com/11570058/diff/1/remoting/client/plugin/pepper_view.cc#oldcode92 remoting/client/plugin/pepper_view.cc:92: // is lousy, so we don't. I take ...
8 years ago (2012-12-18 19:45:32 UTC) #2
Wez
https://chromiumcodereview.appspot.com/11570058/diff/1/remoting/client/plugin/pepper_view.cc File remoting/client/plugin/pepper_view.cc (left): https://chromiumcodereview.appspot.com/11570058/diff/1/remoting/client/plugin/pepper_view.cc#oldcode92 remoting/client/plugin/pepper_view.cc:92: // is lousy, so we don't. On 2012/12/18 19:45:32, ...
8 years ago (2012-12-18 19:47:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/11570058/1
8 years ago (2012-12-18 19:49:01 UTC) #4
commit-bot: I haz the power
8 years ago (2012-12-18 23:59:51 UTC) #5
Message was sent while issue was closed.
Change committed as 173807

Powered by Google App Engine
This is Rietveld 408576698