Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: chrome/test/reliability/page_load_test.cc

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head again, previous had unrelated broken win_rel test. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/testing_profile.cc ('k') | chrome_frame/test/reliability/page_load_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/reliability/page_load_test.cc
diff --git a/chrome/test/reliability/page_load_test.cc b/chrome/test/reliability/page_load_test.cc
index 34012f04e8f8331f63d3dd2b4080c79826f53996..c0590d05c7dc072d4f096fbaa5c2785f37123454 100644
--- a/chrome/test/reliability/page_load_test.cc
+++ b/chrome/test/reliability/page_load_test.cc
@@ -754,16 +754,18 @@ class PageLoadTest : public UITest {
// Get a PrefService whose contents correspond to the Local State file
// that was saved by the app as it closed. The caller takes ownership of the
// returned PrefService object.
- PrefService* GetLocalState() {
+ PrefServiceSimple* GetLocalState() {
FilePath path = user_data_dir().Append(chrome::kLocalStateFilename);
- return PrefServiceMockBuilder().WithUserFilePrefs(
- path, MessageLoop::current()->message_loop_proxy()).Create();
+ PrefServiceMockBuilder builder;
+ builder.WithUserFilePrefs(path,
+ MessageLoop::current()->message_loop_proxy());
+ return builder.CreateSimple();
}
void GetStabilityMetrics(NavigationMetrics* metrics) {
if (!metrics)
return;
- scoped_ptr<PrefService> local_state(GetLocalState());
+ scoped_ptr<PrefServiceSimple> local_state(GetLocalState());
if (!local_state.get())
return;
local_state->RegisterBooleanPref(prefs::kStabilityExitedCleanly, false);
« no previous file with comments | « chrome/test/base/testing_profile.cc ('k') | chrome_frame/test/reliability/page_load_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698