Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head again, previous had unrelated broken win_rel test. Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h" 5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/base64.h" 8 #include "base/base64.h"
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 ManagementPolicy* policy) 99 ManagementPolicy* policy)
100 : extension_service_(service), 100 : extension_service_(service),
101 management_policy_(policy), 101 management_policy_(policy),
102 ignore_notifications_(false), 102 ignore_notifications_(false),
103 deleting_rvh_(NULL), 103 deleting_rvh_(NULL),
104 registered_for_notifications_(false), 104 registered_for_notifications_(false),
105 ALLOW_THIS_IN_INITIALIZER_LIST(warning_service_observer_(this)) { 105 ALLOW_THIS_IN_INITIALIZER_LIST(warning_service_observer_(this)) {
106 } 106 }
107 107
108 // static 108 // static
109 void ExtensionSettingsHandler::RegisterUserPrefs(PrefService* prefs) { 109 void ExtensionSettingsHandler::RegisterUserPrefs(PrefServiceSyncable* prefs) {
110 prefs->RegisterBooleanPref(prefs::kExtensionsUIDeveloperMode, 110 prefs->RegisterBooleanPref(prefs::kExtensionsUIDeveloperMode,
111 false, 111 false,
112 PrefService::SYNCABLE_PREF); 112 PrefServiceSyncable::SYNCABLE_PREF);
113 } 113 }
114 114
115 DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue( 115 DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
116 const Extension* extension, 116 const Extension* extension,
117 const std::vector<ExtensionPage>& pages, 117 const std::vector<ExtensionPage>& pages,
118 const extensions::ExtensionWarningService* warning_service) { 118 const extensions::ExtensionWarningService* warning_service) {
119 DictionaryValue* extension_data = new DictionaryValue(); 119 DictionaryValue* extension_data = new DictionaryValue();
120 bool enabled = extension_service_->IsExtensionEnabled(extension->id()); 120 bool enabled = extension_service_->IsExtensionEnabled(extension->id());
121 extension->GetBasicInfo(enabled, extension_data); 121 extension->GetBasicInfo(enabled, extension_data);
122 122
(...skipping 879 matching lines...) Expand 10 before | Expand all | Expand 10 after
1002 std::vector<std::string> requirement_errors) { 1002 std::vector<std::string> requirement_errors) {
1003 if (requirement_errors.empty()) { 1003 if (requirement_errors.empty()) {
1004 extension_service_->EnableExtension(extension_id); 1004 extension_service_->EnableExtension(extension_id);
1005 } else { 1005 } else {
1006 ExtensionErrorReporter::GetInstance()->ReportError( 1006 ExtensionErrorReporter::GetInstance()->ReportError(
1007 UTF8ToUTF16(JoinString(requirement_errors, ' ')), 1007 UTF8ToUTF16(JoinString(requirement_errors, ' ')),
1008 true /* be noisy */); 1008 true /* be noisy */);
1009 } 1009 }
1010 requirements_checker_.reset(); 1010 requirements_checker_.reset();
1011 } 1011 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_settings_handler.h ('k') | chrome/browser/ui/webui/flags_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698