Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Side by Side Diff: chrome/browser/prefs/pref_service_builder.h

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head again, previous had unrelated broken win_rel test. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/prefs/pref_service.cc ('k') | chrome/browser/prefs/pref_service_builder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PREFS_PREF_SERVICE_BUILDER_H_ 5 #ifndef CHROME_BROWSER_PREFS_PREF_SERVICE_BUILDER_H_
6 #define CHROME_BROWSER_PREFS_PREF_SERVICE_BUILDER_H_ 6 #define CHROME_BROWSER_PREFS_PREF_SERVICE_BUILDER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "base/prefs/persistent_pref_store.h" 11 #include "base/prefs/persistent_pref_store.h"
12 #include "base/prefs/pref_store.h" 12 #include "base/prefs/pref_store.h"
13 13
14 class FilePath; 14 class FilePath;
15 class PrefModelAssociator; 15 class PrefServiceSimple;
16 class PrefService;
17 16
18 namespace base { 17 namespace base {
19 class SequencedTaskRunner; 18 class SequencedTaskRunner;
20 } 19 }
21 20
22 // A class that allows convenient building of custom PrefServices. 21 // A class that allows convenient building of PrefService.
23 class PrefServiceBuilder { 22 class PrefServiceBuilder {
24 public: 23 public:
25 PrefServiceBuilder(); 24 PrefServiceBuilder();
26 virtual ~PrefServiceBuilder(); 25 virtual ~PrefServiceBuilder();
27 26
28 // Functions for setting the various parameters of the PrefService to build. 27 // Functions for setting the various parameters of the PrefService to build.
29 // These take ownership of the |store| parameter. 28 // These take ownership of the |store| parameter.
30 PrefServiceBuilder& WithManagedPrefs(PrefStore* store); 29 PrefServiceBuilder& WithManagedPrefs(PrefStore* store);
31 PrefServiceBuilder& WithExtensionPrefs(PrefStore* store); 30 PrefServiceBuilder& WithExtensionPrefs(PrefStore* store);
32 PrefServiceBuilder& WithCommandLinePrefs(PrefStore* store); 31 PrefServiceBuilder& WithCommandLinePrefs(PrefStore* store);
33 PrefServiceBuilder& WithUserPrefs(PersistentPrefStore* store); 32 PrefServiceBuilder& WithUserPrefs(PersistentPrefStore* store);
34 PrefServiceBuilder& WithRecommendedPrefs(PrefStore* store); 33 PrefServiceBuilder& WithRecommendedPrefs(PrefStore* store);
35 34
36 // Takes ownership of the associator.
37 PrefServiceBuilder& WithSyncAssociator(PrefModelAssociator* associator);
38
39 // Sets up error callback for the PrefService. A do-nothing default 35 // Sets up error callback for the PrefService. A do-nothing default
40 // is provided if this is not called. 36 // is provided if this is not called.
41 PrefServiceBuilder& WithReadErrorCallback( 37 PrefServiceBuilder& WithReadErrorCallback(
42 const base::Callback<void(PersistentPrefStore::PrefReadError)>& 38 const base::Callback<void(PersistentPrefStore::PrefReadError)>&
43 read_error_callback); 39 read_error_callback);
44 40
45 // Specifies to use an actual file-backed user pref store. 41 // Specifies to use an actual file-backed user pref store.
46 PrefServiceBuilder& WithUserFilePrefs( 42 PrefServiceBuilder& WithUserFilePrefs(
47 const FilePath& prefs_file, 43 const FilePath& prefs_file,
48 base::SequencedTaskRunner* task_runner); 44 base::SequencedTaskRunner* task_runner);
49 45
50 PrefServiceBuilder& WithAsync(bool async); 46 PrefServiceBuilder& WithAsync(bool async);
51 47
52 // Creates the PrefService, invalidating the entire builder configuration. 48 // Creates a PrefServiceSimple object initialized with the
53 virtual PrefService* Create(); 49 // parameters from this builder.
50 virtual PrefServiceSimple* CreateSimple();
54 51
55 protected: 52 protected:
53 virtual void ResetDefaultState();
54
56 scoped_refptr<PrefStore> managed_prefs_; 55 scoped_refptr<PrefStore> managed_prefs_;
57 scoped_refptr<PrefStore> extension_prefs_; 56 scoped_refptr<PrefStore> extension_prefs_;
58 scoped_refptr<PrefStore> command_line_prefs_; 57 scoped_refptr<PrefStore> command_line_prefs_;
59 scoped_refptr<PersistentPrefStore> user_prefs_; 58 scoped_refptr<PersistentPrefStore> user_prefs_;
60 scoped_refptr<PrefStore> recommended_prefs_; 59 scoped_refptr<PrefStore> recommended_prefs_;
61 60
62 // TODO(joi): Would be nice to switch the various places that deal
63 // with this pointer to using scoped_ptr::Pass semantics.
64 PrefModelAssociator* sync_associator_;
65
66 base::Callback<void(PersistentPrefStore::PrefReadError)> read_error_callback_; 61 base::Callback<void(PersistentPrefStore::PrefReadError)> read_error_callback_;
67 62
68 // Defaults to false. 63 // Defaults to false.
69 bool async_; 64 bool async_;
70 65
71 private: 66 private:
72 void ResetDefaultState();
73
74 DISALLOW_COPY_AND_ASSIGN(PrefServiceBuilder); 67 DISALLOW_COPY_AND_ASSIGN(PrefServiceBuilder);
75 }; 68 };
76 69
77 #endif // CHROME_BROWSER_PREFS_PREF_SERVICE_BUILDER_H_ 70 #endif // CHROME_BROWSER_PREFS_PREF_SERVICE_BUILDER_H_
OLDNEW
« no previous file with comments | « chrome/browser/prefs/pref_service.cc ('k') | chrome/browser/prefs/pref_service_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698