Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.

chrome/browser/policy/policy_prefs_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <map>
 #include <sstream>
 #include <string>
 #include <vector>
 
@@ skipping 412 matching lines @@
 
   for (ScopedVector<PrefMapping>::const_iterator
            pref_mapping = pref_mappings.begin();
        pref_mapping != pref_mappings.end();
        ++pref_mapping) {
     // Skip Chrome OS preferences that use a different backend and cannot be
     // retrieved through the prefs mechanism.
     if (StartsWithASCII((*pref_mapping)->pref(), kCrosSettingsPrefix, true))
       continue;
 
+    PrefService* local_state = g_browser_process->local_state();
+    PrefService* user_prefs = browser()->profile()->GetPrefs();
     PrefService* prefs = (*pref_mapping)->is_local_state() ?
-        g_browser_process->local_state() : browser()->profile()->GetPrefs();
+        local_state : user_prefs;
     // The preference must have been registered.
     const PrefService::Preference* pref =
         prefs->FindPreference((*pref_mapping)->pref().c_str());
     ASSERT_TRUE(pref);
     prefs->ClearPref((*pref_mapping)->pref().c_str());
 
     // Verify that setting the policy overrides the pref.
     const PolicyMap kNoPolicies;
     provider_.UpdateChromePolicy(kNoPolicies);
     EXPECT_TRUE(pref->IsDefaultValue());
@@ skipping 68 matching lines @@
                         POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER);
       provider_.UpdateChromePolicy(policies);
       VerifyControlledSettingIndicators(browser(), indicator_selector,
                                         (*indicator_test_case)->value(),
                                         "policy",
                                         (*indicator_test_case)->readonly());
 
       if (!policy_test_case->can_be_recommended())
         continue;
 
+      PrefService* local_state = g_browser_process->local_state();
+      PrefService* user_prefs = browser()->profile()->GetPrefs();
       PrefService* prefs = (*pref_mapping)->is_local_state() ?
-          g_browser_process->local_state() : browser()->profile()->GetPrefs();
+          local_state : user_prefs;
       // The preference must have been registered.
       const PrefService::Preference* pref =
           prefs->FindPreference((*pref_mapping)->pref().c_str());
       ASSERT_TRUE(pref);
 
       // Check that the appropriate controlled setting indicator is shown when a
       // value is recommended by policy and the user has not overridden the
       // recommendation.
       policies.LoadFrom(&(*indicator_test_case)->policy(),
                         POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER);
@@ skipping 15 matching lines @@
   }
 }
 
 INSTANTIATE_TEST_CASE_P(
     PolicyPrefsTestInstance,
     PolicyPrefsTest,
     testing::ValuesIn(GetChromePolicyDefinitionList()->begin,
                       GetChromePolicyDefinitionList()->end));
 
 }  // namespace policy