Mark unused Android user actions as deprecated in actions.xml

Mark unused Android user actions as deprecated in actions.xml

BUG=None
TEST=None

Committed: https://crrev.com/a4cb4af3543c3fdd6a6bcc4803c2d1a44ce79acb
Cr-Commit-Position: refs/heads/master@{#331656}

[pkotwicz, 2015-05-26 02:04:58]

pkotwicz@chromium.org changed reviewers:
+ aurimas@chromium.org, jdduke@chromium.org

[pkotwicz, 2015-05-26 02:04:58]

jdduke@ and aurimas@ can you please look at the changes for the user actions
that you are owners of?

I am unsure whether the removal of the MobilePullGestureReload was intentional

Notes:
MobileTabStripNewTab, MobileTabStripCloseTab became unused as a result of
https://gerrit-int.chromium.org/182455

MobileTabStripNewTab feature removed by https://gerrit-int.chromium.org/44917

MobileShortcutAllBookmarks, MobileMenuBack became unused as a result of
https://gerrit-int.chromium.org/174509

MobileNTPSwitchToIncognito became unused as a result of
https://gerrit-int.chromium.org/159647

MobileNTPSwitchToMostVisited became unused as a result of
https://gerrit-int.chromium.org/170640

[jdduke (slow), 2015-05-26 15:13:07]

On 2015/05/26 02:04:58, pkotwicz wrote:
> jdduke@ and aurimas@ can you please look at the changes for the user actions
> that you are owners of?
> 
> I am unsure whether the removal of the MobilePullGestureReload was intentional

Oh snap, good catch, that one was definitely unintentional. I'll whip up a fix,
thanks.

[jdduke (slow), 2015-05-26 15:13:48]

https://codereview.chromium.org/1156943003/diff/1/tools/metrics/actions/actio...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/1156943003/diff/1/tools/metrics/actions/actio...
tools/metrics/actions/actions.xml:7889: <obsolete>
Yeah, there was a refactoring in M44 that removed the hook, I'll add it back in
and merge to M44.

[aurimas (slooooooooow), 2015-05-26 16:41:01]

lgtm

https://chromiumcodereview.appspot.com/1156943003/diff/1/tools/metrics/action...
File tools/metrics/actions/actions.xml (right):

https://chromiumcodereview.appspot.com/1156943003/diff/1/tools/metrics/action...
tools/metrics/actions/actions.xml:7487: <action
name="MobileContextMenuCopyImageLinkAddress">
Could we actually start tracking this instead of deprecating?

[pkotwicz, 2015-05-27 00:45:06]

https://codereview.chromium.org/1156943003/diff/1/tools/metrics/actions/actio...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/1156943003/diff/1/tools/metrics/actions/actio...
tools/metrics/actions/actions.xml:7487: <action
name="MobileContextMenuCopyImageLinkAddress">
I have removed the change to this action (undeprecated it). I will start
tracking this metric after this CL lands. Looking into adding the tracking made
me find http://crbug.com/492446 I am going to look into fixing that bug first

[jdduke (slow), 2015-05-27 17:14:29]

jdduke@chromium.org changed reviewers:
+ newt@chromium.org

[jdduke (slow), 2015-05-27 17:14:30]

Thanks, +newt just to verify this was all intentional.

[newt (away), 2015-05-27 18:28:44]

newt@chromium.org changed reviewers:
+ dtrainor@chromium.org

[newt (away), 2015-05-27 18:28:44]

These metrics were all intentionally removed, except perhaps
MobileTabStripNewTab and MobileTabStripCloseTab.

dtrainor: Do we record metrics equivalent to MobileTabStripNewTab and
MobileTabStripCloseTab? If not, do we want to start recording these again?

[newt (away), 2015-05-27 18:29:42]

On 2015/05/27 18:28:44, newt wrote:
> These metrics were all intentionally removed, except perhaps
> MobileTabStripNewTab and MobileTabStripCloseTab.
> 
> dtrainor: Do we record metrics equivalent to MobileTabStripNewTab and
> MobileTabStripCloseTab? If not, do we want to start recording these again?

btw, MobileTabStripNewTab and MobileTabStripCloseTab were removed in Carson's CL
which deleted the old tabstrip implementation:
https://chrome-internal-review.googlesource.com/182455

[David Trainor- moved to gerrit, 2015-05-27 19:46:32]

On 2015/05/27 18:29:42, newt wrote:
> On 2015/05/27 18:28:44, newt wrote:
> > These metrics were all intentionally removed, except perhaps
> > MobileTabStripNewTab and MobileTabStripCloseTab.
> > 
> > dtrainor: Do we record metrics equivalent to MobileTabStripNewTab and
> > MobileTabStripCloseTab? If not, do we want to start recording these again?
> 
> btw, MobileTabStripNewTab and MobileTabStripCloseTab were removed in Carson's
CL
> which deleted the old tabstrip implementation:
> https://chrome-internal-review.googlesource.com/182455

It looks like we don't.  It's been a while since it's been removed and it seems
like nobody has mentioned it, so it might be a good reason to let it drop. 
However if we want to add it we just need to update StripLayoutHelper#click() to
log the metrics at the appropriate times conditional blocks.

[newt (away), 2015-05-27 19:48:30]

On 2015/05/27 19:46:32, David Trainor wrote:
> On 2015/05/27 18:29:42, newt wrote:
> > On 2015/05/27 18:28:44, newt wrote:
> > > These metrics were all intentionally removed, except perhaps
> > > MobileTabStripNewTab and MobileTabStripCloseTab.
> > > 
> > > dtrainor: Do we record metrics equivalent to MobileTabStripNewTab and
> > > MobileTabStripCloseTab? If not, do we want to start recording these again?
> > 
> > btw, MobileTabStripNewTab and MobileTabStripCloseTab were removed in
Carson's
> CL
> > which deleted the old tabstrip implementation:
> > https://chrome-internal-review.googlesource.com/182455
> 
> It looks like we don't.  It's been a while since it's been removed and it
seems
> like nobody has mentioned it, so it might be a good reason to let it drop. 
> However if we want to add it we just need to update StripLayoutHelper#click()
to
> log the metrics at the appropriate times conditional blocks.

Ok. I'm fine with not resurrecting those tab strip metrics. lgtm.

[pkotwicz, 2015-05-27 20:33:09]

pkotwicz@chromium.org changed reviewers:
+ isherman@chromium.org

[pkotwicz, 2015-05-27 20:33:10]

isherman@ for OWNERS

[Ilya Sherman, 2015-05-27 20:34:26]

LGTM.  Thanks for the cleanup.

[pkotwicz, 2015-05-27 21:16:12]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-05-27 21:16:13]

The patchset sent to the CQ was uploaded after l-g-t-m from aurimas@chromium.org
Link to the patchset: https://codereview.chromium.org/1156943003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-05-27 21:25:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1156943003/40001

[commit-bot: I haz the power, 2015-05-27 21:38:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-27 21:40:19]

Patchset 3 (id:??) landed as
https://crrev.com/a4cb4af3543c3fdd6a6bcc4803c2d1a44ce79acb
Cr-Commit-Position: refs/heads/master@{#331656}