Suggest owners for OWNERS files that only have per-file owners.

Suggest owners for OWNERS files that only have per-file owners.

If you were creating a new OWNERS file that only had per-file owners
in it (and no catch-all owners for the whole directory), then we
would not look for suggested owners in parent directories, and end up
suggesting nothing. See https://chromiumcodereview.appspot.com/11555036/
for the CL that revealed this.

Also, the unit tests were incorrectly using absolute paths in some cases,
making the code less predictable; I've fixed the unit tests and added
a check for this into owners.py (real changes never used absolute paths,
just paths relative to the checkout root).

R=maruel@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=173000

[M-A Ruel, 2012-12-13 23:25:15]

lgtm

https://codereview.chromium.org/11569018/diff/1/testing_support/filesystem_mo...
File testing_support/filesystem_mock.py (right):

https://codereview.chromium.org/11569018/diff/1/testing_support/filesystem_mo...
testing_support/filesystem_mock.py:50: return path.startswith(self.sep)
I assume you don't mind if this doesn't pass on Windows.

[Dirk Pranke, 2012-12-13 23:28:31]

On 2012/12/13 23:25:15, Marc-Antoine Ruel wrote:
> lgtm
> 
>
https://codereview.chromium.org/11569018/diff/1/testing_support/filesystem_mo...
> File testing_support/filesystem_mock.py (right):
> 
>
https://codereview.chromium.org/11569018/diff/1/testing_support/filesystem_mo...
> testing_support/filesystem_mock.py:50: return path.startswith(self.sep)
> I assume you don't mind if this doesn't pass on Windows.

correct; they're mocks, after all.

[commit-bot: I haz the power, 2012-12-13 23:34:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpranke@chromium.org/11569018/1

[commit-bot: I haz the power, 2012-12-13 23:37:24]

Change committed as 173000