Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11568042: Some initial changes for manipulating the top controls positions on Android. (Closed)

Created:
8 years ago by Ted C
Modified:
8 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Some initial changes for manipulating the top controls positions on Android. Needed to modify ZoomManager to ensure it sends scrollEnd events in all circumstances. Previously, the zoom manager was always marking UP events as handled even if it took no action on the down event. BUG=161303 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173637

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Added additional flag that will be needed by the cc layer. #

Total comments: 4

Patch Set 4 : Review comments #

Messages

Total messages: 11 (0 generated)
Ted C
8 years ago (2012-12-14 21:40:41 UTC) #1
David Trainor- moved to gerrit
lgtm https://chromiumcodereview.appspot.com/11568042/diff/6001/content/browser/android/content_view_core_impl.h File content/browser/android/content_view_core_impl.h (right): https://chromiumcodereview.appspot.com/11568042/diff/6001/content/browser/android/content_view_core_impl.h#newcode213 content/browser/android/content_view_core_impl.h:213: void UpdateOffsetsForFullscreen(float controls_offset, float content_offset); Should this be ...
8 years ago (2012-12-17 18:31:32 UTC) #2
Ted C
https://chromiumcodereview.appspot.com/11568042/diff/6001/content/browser/android/content_view_core_impl.h File content/browser/android/content_view_core_impl.h (right): https://chromiumcodereview.appspot.com/11568042/diff/6001/content/browser/android/content_view_core_impl.h#newcode213 content/browser/android/content_view_core_impl.h:213: void UpdateOffsetsForFullscreen(float controls_offset, float content_offset); On 2012/12/17 18:31:32, dtrainor ...
8 years ago (2012-12-17 18:39:48 UTC) #3
Yusuf
lgtm
8 years ago (2012-12-17 18:51:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/11568042/10001
8 years ago (2012-12-17 18:54:00 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
8 years ago (2012-12-17 22:23:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/11568042/10001
8 years ago (2012-12-17 22:38:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/11568042/10001
8 years ago (2012-12-18 01:06:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/11568042/10001
8 years ago (2012-12-18 01:55:23 UTC) #9
commit-bot: I haz the power
Change committed as 173637
8 years ago (2012-12-18 03:43:41 UTC) #10
Isaac (away)
8 years ago (2012-12-19 08:04:52 UTC) #11
Message was sent while issue was closed. 
Reverted in crrev.com/11642012 as a probably cause on android flakiness.  In
particular, I suspect it is causing 

CRITICAL:root:org.chromium.content.browser.ContentViewPopupZoomerTest#testPopupZoomerShowsUp
CRITICAL:root:junit.framework.AssertionFailedError: The zoomer popup did not
show up on click.
	at
org.chromium.content.browser.ContentViewPopupZoomerTest.testPopupZoomerShowsUp(ContentViewPopupZoomerTest.java:99)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at
android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at
android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at
android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154)
	at
android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:545)
	at
android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1551)

Powered by Google App Engine
This is Rietveld 408576698