Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 11568039: Fix eyesfree aidl rules/deps (Closed)

Created:
8 years ago by David Trainor- moved to gerrit
Modified:
8 years ago
Reviewers:
Ted C, cjhopman, nyquist
CC:
chromium-reviews
Visibility:
Public.

Description

Fix eyesfree aidl rules/deps - Remove aidl targets that don't produce outputs - Fix java_aidl to depend on the import java src BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M build/java_aidl.gypi View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/eyesfree/eyesfree.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
David Trainor- moved to gerrit
ptal
8 years ago (2012-12-14 19:53:07 UTC) #1
nyquist
lgtm
8 years ago (2012-12-14 21:14:45 UTC) #2
cjhopman
lgtm
8 years ago (2012-12-14 23:29:47 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years ago (2012-12-14 23:33:01 UTC) #4
David Trainor- moved to gerrit
8 years ago (2012-12-14 23:37:37 UTC) #5
Ted C
lgtm
8 years ago (2012-12-14 23:38:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/11568039/1
8 years ago (2012-12-14 23:38:50 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-15 04:07:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/11568039/1
8 years ago (2012-12-15 11:01:33 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-15 14:15:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/11568039/1
8 years ago (2012-12-15 19:50:12 UTC) #11
commit-bot: I haz the power
8 years ago (2012-12-15 22:30:28 UTC) #12
Message was sent while issue was closed.
Change committed as 173333

Powered by Google App Engine
This is Rietveld 408576698