Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 11568038: Add g++-multilib build dependency when cross building for ARM. (Closed)

Created:
8 years ago by Sam Clegg
Modified:
8 years ago
Reviewers:
iannucci
CC:
chromium-reviews
Visibility:
Public.

Description

Add g++-multilib build dependency when cross building for ARM. We found that this package is needed on 64-bit systems when cross compiling for ARM due to the requirment that v8 host binaries be build with -m32 (they must run with same pointer size as target platform apparently). BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173568

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M build/install-build-deps.sh View 2 chunks +8 lines, -2 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
Sam Clegg
This should avoid the need for any extra package installation on the arm buildbots.
8 years ago (2012-12-14 19:37:51 UTC) #1
Sam Clegg
ping.
8 years ago (2012-12-17 17:49:42 UTC) #2
iannucci
https://chromiumcodereview.appspot.com/11568038/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (left): https://chromiumcodereview.appspot.com/11568038/diff/1/build/install-build-deps.sh#oldcode109 build/install-build-deps.sh:109: cpp-4.5-arm-linux-gnueabi gcc-4.5-arm-linux-gnueabi Are we sure these AREN'T used? Or ...
8 years ago (2012-12-17 19:52:23 UTC) #3
Sam Clegg
On 2012/12/17 19:52:23, iannucci wrote: > https://chromiumcodereview.appspot.com/11568038/diff/1/build/install-build-deps.sh > File build/install-build-deps.sh (left): > > https://chromiumcodereview.appspot.com/11568038/diff/1/build/install-build-deps.sh#oldcode109 > ...
8 years ago (2012-12-17 19:56:16 UTC) #4
Sam Clegg
On 2012/12/17 19:52:23, iannucci wrote: > https://chromiumcodereview.appspot.com/11568038/diff/1/build/install-build-deps.sh > File build/install-build-deps.sh (left): > > https://chromiumcodereview.appspot.com/11568038/diff/1/build/install-build-deps.sh#oldcode109 > ...
8 years ago (2012-12-17 19:56:38 UTC) #5
iannucci
lgtm
8 years ago (2012-12-17 19:57:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/11568038/1
8 years ago (2012-12-17 20:10:31 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-17 23:31:45 UTC) #8
Message was sent while issue was closed.
Change committed as 173568

Powered by Google App Engine
This is Rietveld 408576698