Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: net/cookies/cookie_monster_unittest.cc

Issue 11568033: Small fixes to allow unit tests to compile with gcc 4.7.x (tested with gcc 4.7.2) (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cookies/cookie_monster_perftest.cc ('k') | net/spdy/spdy_http_stream_spdy3_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/cookie_monster_unittest.cc
===================================================================
--- net/cookies/cookie_monster_unittest.cc (revision 174065)
+++ net/cookies/cookie_monster_unittest.cc (working copy)
@@ -1725,11 +1725,11 @@
// time and size of store to make sure we only get rid of cookies when
// we really should.
const struct TestCase {
- int num_cookies;
- int num_old_cookies;
- int expected_initial_cookies;
+ size_t num_cookies;
+ size_t num_old_cookies;
+ size_t expected_initial_cookies;
// Indexed by ExpiryAndKeyScheme
- int expected_cookies_after_set;
+ size_t expected_cookies_after_set;
} test_cases[] = {
{
// A whole lot of recent cookies; gc shouldn't happen.
@@ -1765,13 +1765,11 @@
CreateMonsterFromStoreForGC(
test_case->num_cookies, test_case->num_old_cookies,
CookieMonster::kSafeFromGlobalPurgeDays * 2));
- EXPECT_EQ(test_case->expected_initial_cookies,
- static_cast<int>(GetAllCookies(cm).size()))
+ EXPECT_EQ(test_case->expected_initial_cookies, GetAllCookies(cm).size())
<< "For test case " << ci;
// Will trigger GC
SetCookie(cm, GURL("http://newdomain.com"), "b=2");
- EXPECT_EQ(test_case->expected_cookies_after_set,
- static_cast<int>((GetAllCookies(cm).size())))
+ EXPECT_EQ(test_case->expected_cookies_after_set, GetAllCookies(cm).size())
<< "For test case " << ci;
}
}
« no previous file with comments | « net/cookies/cookie_monster_perftest.cc ('k') | net/spdy/spdy_http_stream_spdy3_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698