Small fixes to allow unit tests to compile with gcc 4.7.x (tested with gcc 4.7.2)

Small fixes to allow unit tests to compile with gcc 4.7.x (tested with gcc 4.7.2)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174956

[Paweł Hajdan Jr., 2012-12-14 18:10:14]

LGTM

Please do OWNERS review:

Jim: base & net
James: chrome

[jar (doing other things), 2012-12-14 18:37:23]

Patch set 1:   Base lgtm

[James Hawkins, 2012-12-14 19:39:55]

lgtm

[commit-bot: I haz the power, 2012-12-14 19:55:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kamil.jiwa@gmail.com/11568033/1

[commit-bot: I haz the power, 2012-12-14 19:55:31]

Presubmit check for 11568033-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit Warnings **
kamil.jiwa@gmail.com is not in AUTHORS file. If you are a new contributor,
please visit
http://www.chromium.org/developers/contributing-code and read the "Legal"
section
If you are a chromite, verify the contributor signed the CLA.

Presubmit checks took 1.2s to calculate.

[Ryan Sleevi, 2012-12-14 20:33:40]

On 2012/12/14 19:55:31, I haz the power (commit-bot) wrote:
> Presubmit check for 11568033-1 failed and returned exit status 1.
> 
> 
> Running presubmit commit checks ...
> 
> ** Presubmit Messages **
> If this change has an associated bug, add BUG=[bug number].
> 
> ** Presubmit Warnings **
> mailto:kamil.jiwa@gmail.com is not in AUTHORS file. If you are a new
contributor,
> please visit
> http://www.chromium.org/developers/contributing-code and read the "Legal"
> section
> If you are a chromite, verify the contributor signed the CLA.
> 
> Presubmit checks took 1.2s to calculate.

Note: I've verified that the address is on file as an Individual CLA.

Kamil will update the AUTHORS file in a subsequent patch, but it should be good
to go then.

[commit-bot: I haz the power, 2012-12-15 18:10:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kamil.jiwa@gmail.com/11568033/1012

[commit-bot: I haz the power, 2012-12-15 18:22:33]

Sorry for I got bad news for ya.
Compile failed with a clobber build on ios_dbg_simulator.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Kamil Jiwa, 2012-12-18 09:28:39]

Small fixes to allow unit tests to compile with gcc 4.7.x (tested with gcc
4.7.2)

[Kamil Jiwa, 2012-12-19 05:41:14]

Adding owners:

- albertb@ for chrome/browser/password_manager
- dominich@ for chrome/browser/predictors
- piman@ for gpu
- akalin@ for sync

[piman, 2012-12-19 08:45:33]

https://codereview.chromium.org/11568033/diff/23001/gpu/command_buffer/tests/...
File gpu/command_buffer/tests/gl_pointcoord_unittest.cc (right):

https://codereview.chromium.org/11568033/diff/23001/gpu/command_buffer/tests/...
gpu/command_buffer/tests/gl_pointcoord_unittest.cc:42: double vertices[] = {
NAK, this needs to stay an array of floats. Maybe you want to change the values
into -0.5f + pixel_offset, etc.

[Kamil Jiwa, 2012-12-20 04:25:06]

On 2012/12/19 08:45:33, piman wrote:
>
https://codereview.chromium.org/11568033/diff/23001/gpu/command_buffer/tests/...
> File gpu/command_buffer/tests/gl_pointcoord_unittest.cc (right):
> 
>
https://codereview.chromium.org/11568033/diff/23001/gpu/command_buffer/tests/...
> gpu/command_buffer/tests/gl_pointcoord_unittest.cc:42: double vertices[] = {
> NAK, this needs to stay an array of floats. Maybe you want to change the
values
> into -0.5f + pixel_offset, etc.

Updated this and also verified that gpu_tests runs successfully.

[piman, 2012-12-20 04:36:30]

LGTM for gpu/

[Kamil Jiwa, 2012-12-22 02:51:27]

On 2012/12/20 04:36:30, piman wrote:
> LGTM for gpu/

Thanks. Updating reviewers:

- tim@ for chrome/browser/password_manager and sync/
- shishir@ for chrome/browser/predictors

[Shishir, 2012-12-26 21:18:45]

predictors: LGTM

[akalin, 2012-12-29 09:57:43]

sync lgtm

[tim (not reviewing), 2013-01-03 04:22:38]

On 2012/12/29 09:57:43, akalin wrote:
> sync lgtm

password_manager/ LGTM

[commit-bot: I haz the power, 2013-01-03 06:02:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kamil.jiwa@gmail.com/11568033/33001

[commit-bot: I haz the power, 2013-01-03 12:30:55]

Change committed as 174956