Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 11568027: cc: Add TileManager interface that allows LTHI to determine when to activate pending tree. (Closed)

Created:
8 years ago by reveman
Modified:
8 years ago
Reviewers:
nduca, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Add TileManager interface that allows LTHI to determine when to activate pending tree. BUG=166072 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173385

Patch Set 1 #

Patch Set 2 : Determine bin for each tree. #

Total comments: 1

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -40 lines) Patch
M cc/layer_tree_host_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/tile_manager.h View 1 2 4 chunks +11 lines, -2 lines 0 comments Download
M cc/tile_manager.cc View 1 2 10 chunks +81 lines, -36 lines 0 comments Download
M cc/tile_priority.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
reveman
How about something like this to determine when to activate pending tree?
8 years ago (2012-12-14 03:43:09 UTC) #1
enne (OOO)
I kind of tink there needs to be a way to differentiate between what the ...
8 years ago (2012-12-14 17:35:57 UTC) #2
reveman
On 2012/12/14 17:35:57, enne wrote: > I kind of tink there needs to be a ...
8 years ago (2012-12-14 19:03:41 UTC) #3
enne (OOO)
That sounds great to me.
8 years ago (2012-12-14 19:06:04 UTC) #4
reveman
This is now determining the bin for each tree priority and LTHI can efficiently ask ...
8 years ago (2012-12-15 21:05:40 UTC) #5
enne (OOO)
lgtm https://codereview.chromium.org/11568027/diff/6001/cc/tile_manager.cc File cc/tile_manager.cc (right): https://codereview.chromium.org/11568027/diff/6001/cc/tile_manager.cc#newcode36 cc/tile_manager.cc:36: cc::TileManagerBin BinFromTilePriority(const cc::TilePriority& prio) { This is a ...
8 years ago (2012-12-16 01:26:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/11568027/8003
8 years ago (2012-12-16 07:30:04 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-16 20:13:45 UTC) #8
Message was sent while issue was closed.
Change committed as 173385

Powered by Google App Engine
This is Rietveld 408576698