Issue 11568023: Skia doesn't depend on harfbuzz, so remove the dependency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11568023: Skia doesn't depend on harfbuzz, so remove the dependency. (Closed)

Created:
8 years ago by tony

Modified:
8 years ago

Reviewers:
Nico, Paweł Hajdan Jr.

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Skia doesn't depend on harfbuzz, so remove the dependency. BUG=68551 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173125

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	skia/skia.gyp	View		3 chunks	+0 lines, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

tony

I think the harfbuzz code in skia was experimental and we don't actually use it.

8 years ago (2012-12-13 23:59:43 UTC) #1

Nico

lgtm! You mentioned that the dependency in webcore isn't real either -- can we remove ...

8 years ago (2012-12-14 00:07:21 UTC) #2

tony

On 2012/12/14 00:07:21, Nico wrote: > lgtm! > > You mentioned that the dependency in ...

8 years ago (2012-12-14 00:11:57 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/11568023/1

8 years ago (2012-12-14 00:17:42 UTC) #4

Message was sent while issue was closed.

Change committed as 173125