Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: include/v8.h

Issue 11568014: Revert r13218 due to windows test failures. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index bfdbbb7553be2ce95bb64c62139a173e67ab4e05..f577e937a5d355a5b67ab4aa68b3680b183e88dd 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -3479,24 +3479,6 @@ class V8EXPORT V8 {
static bool IsExecutionTerminating(Isolate* isolate = NULL);
/**
- * Resume execution capability in the given isolate, whose execution
- * was previously forcefully terminated using TerminateExecution().
- *
- * When execution is forcefully terminated using TerminateExecution(),
- * the isolate can not resume execution until all JavaScript frames
- * have propagated the uncatchable exception which is generated. This
- * method allows the program embedding the engine to handle the
- * termination event and resume execution capability, even if
- * JavaScript frames remain on the stack.
- *
- * This method can be used by any thread even if that thread has not
- * acquired the V8 lock with a Locker object.
- *
- * \param isolate The isolate in which to resume execution capability.
- */
- static void ResumeExecution(Isolate* isolate);
-
- /**
* Releases any resources used by v8 and stops any utility threads
* that may be running. Note that disposing v8 is permanent, it
* cannot be reinitialized.
@@ -3618,28 +3600,18 @@ class V8EXPORT TryCatch {
* For certain types of exceptions, it makes no sense to continue
* execution.
*
+ * Currently, the only type of exception that can be caught by a
+ * TryCatch handler and for which it does not make sense to continue
+ * is termination exception. Such exceptions are thrown when the
+ * TerminateExecution methods are called to terminate a long-running
+ * script.
+ *
* If CanContinue returns false, the correct action is to perform
- * any C++ cleanup needed and then return. If CanContinue returns
- * false and HasTerminated returns true, it is possible to call
- * ResumeExecution in order to continue calling into the engine.
+ * any C++ cleanup needed and then return.
*/
bool CanContinue() const;
/**
- * Returns true if an exception has been caught due to script execution
- * being terminated.
- *
- * There is no JavaScript representation of an execution termination
- * exception. Such exceptions are thrown when the TerminateExecution
- * methods are called to terminate a long-running script.
- *
- * If such an exception has been thrown, HasTerminated will return
- * true, indicating that it is possible to call ResumeExecution in
- * order to continue calling into the engine.
- */
- bool HasTerminated() const;
-
- /**
* Throws the exception caught by this TryCatch in a way that avoids
* it being caught again by this same TryCatch. As with ThrowException
* it is illegal to execute any JavaScript operations after calling
@@ -3714,7 +3686,6 @@ class V8EXPORT TryCatch {
bool can_continue_ : 1;
bool capture_message_ : 1;
bool rethrow_ : 1;
- bool has_terminated_ : 1;
friend class v8::internal::Isolate;
};
« no previous file with comments | « AUTHORS ('k') | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698