Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 11567057: Improve immersive mode light bar painting (Closed)

Created:
8 years ago by James Cook
Modified:
8 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Improve immersive mode light bar painting The light bar looks better with sharp software-renderer rectangles than with the softened art assets we're using. For now, just draw rectangles until we can replace (or remove) the art assets. Also stretch the light bar a little left and right to make it visually match the top line of the tab. BUG=none TEST=visual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M chrome/browser/ui/views/tabs/tab.cc View 3 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
sky, PTAL. I'll sort out whether we remove or replace the art with alcor@ next ...
8 years ago (2012-12-15 01:05:36 UTC) #1
sky
LGTM
8 years ago (2012-12-15 22:23:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/11567057/1
8 years ago (2012-12-17 04:36:01 UTC) #3
commit-bot: I haz the power
8 years ago (2012-12-17 07:53:38 UTC) #4
Message was sent while issue was closed.
Change committed as 173426

Powered by Google App Engine
This is Rietveld 408576698