Fix test-running in --single-process mode.

chrome/browser/profiles/profile_destroyer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_destroyer.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 19 matching lines @@
   // Testing profiles can simply be deleted directly. Some tests don't setup
   // RenderProcessHost correctly and don't necessary run on the UI thread
   // anyway, so we can't use the AllHostIterator.
   if (profile->AsTestingProfile() == NULL) {
     GetHostsForProfile(profile, &hosts);
     if (!profile->IsOffTheRecord() && profile->HasOffTheRecordProfile())
       GetHostsForProfile(profile->GetOffTheRecordProfile(), &hosts);
   }
   // This should never happen for non Off the record profile, this means that
   // there is a leak in a render process host that MUST BE FIXED!!!
-  DCHECK(hosts.empty() || profile->IsOffTheRecord());
+  DCHECK(content::RenderProcessHost::run_renderer_in_process() ||

[MAD, 2012/12/15 00:11:22]

Can you please add a comment stating why we need to do this?

[Jeffrey Yasskin, 2012/12/15 00:31:31]

Sure. Could you explain why off-the-record profiles leave RenderProcessHosts
around so the resulting comment is symmetric?

[MAD, 2012/12/15 04:05:31]

Good point, this is because we don't want to delay destruction of off the record
profile, since they contain private information that has be destroyed as quickly
as possible.

+         hosts.empty() || profile->IsOffTheRecord());
   // Note that we still test for !profile->IsOffTheRecord here even though we
   // DCHECK'd above because we want to protect Release builds against this even
   // we need to identify if there are leaks when we run Debug builds.
   if (hosts.empty() || !profile->IsOffTheRecord()) {
     if (profile->IsOffTheRecord())
       profile->GetOriginalProfile()->DestroyOffTheRecordProfile();
     else
       delete profile;
   } else {
     // The instance will destroy itself once all render process hosts referring
@@ skipping 114 matching lines @@
         content::RenderProcessHost::AllHostsIterator());
       !iter.IsAtEnd(); iter.Advance()) {
     content::RenderProcessHost* render_process_host = iter.GetCurrentValue();
     if (render_process_host && Profile::FromBrowserContext(
           render_process_host->GetBrowserContext()) == profile) {
       hosts->push_back(render_process_host);
     }
   }
   return !hosts->empty();
 }