Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 11567040: [Mac] Website settings: Fix DCHECK that was checking the wrong condition. (Closed)

Created:
8 years ago by Patrick Dubroy
Modified:
8 years ago
CC:
chromium-reviews, sail+watch_chromium.org, markusheintz_, no longer working on chromium
Visibility:
Public.

Description

[Mac] Website settings: Fix DCHECK that was checking the wrong condition. The intention of the DCHECK was to ensure that the permissions view is always laid out before the cookies view. The correct place to do this check is when laying out the cookies view. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/ui/cocoa/website_settings_bubble_controller.mm View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Patrick Dubroy
[cc markusheintz + xians] Robert, please take a look. This is the correct fix for ...
8 years ago (2012-12-14 11:52:11 UTC) #1
markusheintz_
LGTM
8 years ago (2012-12-14 16:49:01 UTC) #2
Robert Sesek
LGTM
8 years ago (2012-12-14 17:11:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/11567040/1
8 years ago (2012-12-14 17:38:51 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-14 21:53:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/11567040/1
8 years ago (2012-12-17 13:34:38 UTC) #6
commit-bot: I haz the power
8 years ago (2012-12-17 15:12:10 UTC) #7
Message was sent while issue was closed.
Change committed as 173464

Powered by Google App Engine
This is Rietveld 408576698