pkg/serialization/lib/src/serialization_rule.dart - Issue 11567018: Get rid of the polyfill identity set implementation in favour of a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/serialization/lib/src/serialization_rule.dart

Issue 11567018: Get rid of the polyfill identity set implementation in favour of a (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: A bit more polyfill that can be removed with this change. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/serialization/lib/src/serialization_helpers.dart ('K') | « pkg/serialization/lib/src/serialization_helpers.dart ('k') | pkg/serialization/test/polyfill_identity_map_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/serialization/lib/src/serialization_rule.dart

diff --git a/pkg/serialization/lib/src/serialization_rule.dart b/pkg/serialization/lib/src/serialization_rule.dart

index a4602373c1f33f40ff2264d3bfe3a6e143f64d6c..289164cddec24070c0db07e729017dddbf4cb11b 100644

--- a/pkg/serialization/lib/src/serialization_rule.dart

+++ b/pkg/serialization/lib/src/serialization_rule.dart

@@ -275,11 +275,6 @@ class PrimitiveRule extends SerializationRule {

}

-/** Helper function for PrimitiveRule to tell which objects it applies to. */

-bool isPrimitive(Object object) {

- return object is num || object is String || object is bool;

/** Typedef for the object construction closure used in ClosureToMapRule. */

typedef Object ConstructType(Map m);