pkg/serialization/lib/serialization.dart - Issue 11567018: Get rid of the polyfill identity set implementation in favour of a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/serialization/lib/serialization.dart

Issue 11567018: Get rid of the polyfill identity set implementation in favour of a (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: A bit more polyfill that can be removed with this change. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/serialization/lib/serialization.dart

diff --git a/pkg/serialization/lib/serialization.dart b/pkg/serialization/lib/serialization.dart

index 1c5f07060085b3410e915c23052ab96b85c88082..459b4b85218a3c03e0ecc282915adb24307784dc 100644

--- a/pkg/serialization/lib/serialization.dart

+++ b/pkg/serialization/lib/serialization.dart

@@ -148,7 +148,6 @@ library serialization;

import 'src/mirrors_helpers.dart';

import 'src/serialization_helpers.dart';

-import 'src/polyfill_identity_set.dart';

import 'dart:json' show JSON;

part 'src/reader_writer.dart';

@@ -383,7 +382,7 @@ class Serialization {

..addRuleFor(new PrimitiveRule())

..addRuleFor(new ListRuleEssential())

..addRuleFor(basicRule,

- constructorFields: ['typeWrapped',

+ constructorFields: ['type',

'constructorName',

'constructorFields', 'regularFields', []],

fields: [])

« no previous file with comments | « no previous file | pkg/serialization/lib/src/basic_rule.dart » ('j') | pkg/serialization/lib/src/serialization_helpers.dart » ('J')